Comments (7)
Shouldn't the convolutional filters be 3 dimensional?
It always is 3-dimensional if you count the filter number in.
with additional depth of 2
The depth is actually the filter number.
I took a screenshot from cs231n, maybe this will help a bit:
edit:
However I think there is a discrepancy between the code and paper on how many (version upgrade)feature_maps
does the first ConvLayer
produces? (In paper is 2 but in code is 3) @ZhengyaoJiang
from pgportfolio.
Shouldn't the convolutional filters be 3 dimensional? I mean, in the original convolution how do we go from 3 feature maps to 2 feature maps. I believe this would make sense if the filter was of dimension 2x1x3 (same as described but with additional depth of 2).
Yes, it is actually 3 dimensional.
While I think it's a convention that the one of the dimension is the same as the number of input channels(features) and can be omitted when it comes to conv2d.
If we are using conv3d, then it is necessary to specify another dimension.
You can refer to tensorflow.layers for example:
https://www.tensorflow.org/api_docs/python/tf/layers/conv2d
However I think there is a discrepancy between the code and paper on how many feature_maps does the first ConvLayer produces?
Number of feature maps is equal to the number of filters.
from pgportfolio.
From my understanding it appears there is still a discrepancy from the paper in {"filter_shape":[1,2]}. The paper implies it should be {"filter_shape":[1,3]}, doesn't it?
Yes, as we mentioned in README, the hyper-parameters are different as that listed in the article.
The new hyper-parameters are tuned by an automatic parameters search algorithm, which saves much training time and preserves(or improve in some time span) final performance.
from pgportfolio.
Thank you, this clears things up. From my understanding it appears there is still a discrepancy from the paper in {"filter_shape":[1,2]}. The paper implies it should be {"filter_shape":[1,3]}, doesn't it?
from pgportfolio.
You can freely play around with the filter size in the first ConvLayer 2, 3 or 5 seem to be values giving reasonable results.
from pgportfolio.
Thank you for the information @ZhengyaoJiang. It is a great paper, and well written code, I really appreciate it. I am a CS master's student at Simon Fraser University, I am basing my current projects off of this paper.
from pgportfolio.
Thanks for your compliment.
Hope your project goes well.
from pgportfolio.
Related Issues (20)
- Three questions HOT 2
- Does your model support no-transction allowed periods
- Meaning of figures like 0.00900002 in SqlLite history table for ETH
- pandas panel HOT 3
- mu might be miscalculated
- A Error in data Processing HOT 1
- validation set and hyperparameters tuning
- question about decide_by_history
- Lower portfolio values for recent dates(e.g. "start_date":"2018/08/17", "end_date":"2020/11/19") HOT 1
- ERROR:root:the sqlite error happend HOT 1
- TypeError: object() takes no parameters HOT 1
- Conversion of globaldatamatrix panel to Dataframe (panel is deprecated) HOT 4
- Fix: train_summary.csv not generated
- Normalization on open price HOT 1
- Problem of dtype arguments
- How to run this agent
- KeyError: 'BTS_BTC' HOT 7
- when I download the data. KeyError: 'BTS_BTC' what is the problem? HOT 5
- non-resource variables are not supported in the long term HOT 1
- last_w is NaN
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pgportfolio.