Coder Social home page Coder Social logo

Comments (8)

puddly avatar puddly commented on July 18, 2024

That's a good idea. Does this require moving the custom component into a module folder?

from zha-custom-radios.

Adminiuga avatar Adminiuga commented on July 18, 2024

Not quite sure I'm following. Maybe we should split the custom_component into it's own repo, but I think we could keep it in here for now and just re-organize ./custom_components/zha_custom_radios.py into ./custom_components/zha_custom_radios/zha_custom_radios.py and add here the __init__.py and manifest.json

If you mean that, then yeah, the custom component should become a module, but not the zigpy_znp module.

If we split into it's own repo, then we could add it to HACS for easier installation.

from zha-custom-radios.

puddly avatar puddly commented on July 18, 2024

Yeah, that's fine.

No part of the custom component hard-codes zigpy-znp so it might be useful as an external module, in case someone wants to write another library for a new radio (I guess NXP and Nordic are the only ones left?) and test it with HA.

from zha-custom-radios.

Adminiuga avatar Adminiuga commented on July 18, 2024

That's a good idea!
With a minor problem of finding a volunteer to write NXP lib 😃

from zha-custom-radios.

Adminiuga avatar Adminiuga commented on July 18, 2024

Sent you the invite, should have enough permission to create a new repo if you decide so

from zha-custom-radios.

puddly avatar puddly commented on July 18, 2024

Thanks. I'll probably give it a try in a couple of days.

from zha-custom-radios.

puddly avatar puddly commented on July 18, 2024

There's no way to make this custom component work, I'm afraid. The manifest.json does get HA to auto-install dependencies but its presence also makes this component load way after zha to do its thing. The only way (as far as I can tell) to actually run code early is to purposefully create a legacy custom component and abuse the fact that it's imported before being loaded: https://github.com/zha-ng/zigpy-znp/blob/dev/custom_components/zha_custom_radios.py

At that point it'd be easier to have the component install zigpy-znp itself, though that's getting a little too complex for my liking.

from zha-custom-radios.

Adminiuga avatar Adminiuga commented on July 18, 2024

Ah, yep. I don't know any other way to make it user friendly.

from zha-custom-radios.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.