grub problems about pkg-zfs

[nergdron]

I'm seeing the same problem trying to run update-grub from inside a chrooted env from the 11.10 live CD:

update-grub

Generating grub.cfg ...
[: 68: missing ]
/etc/grub.d/10_linux: 68: xUNKNOWN (0x2fc12fc1): not found
done

Looking at the code in /etc/grub.d/10_linux, it looks like the offending line is this:
LINUX_ROOT_STAT=stat -f --printf=%T / || true

That stat command returns "UNKNOWN (0x2fc12fc1)" on 11.10 for a zfs mount.

I don't see any similar lines in the upstream grub2 in 11.10, so I'm not sure what it's supposed to do (other than the obvious following stuff for btrfs).

Thankfully, it doesn't seem to affect setting up the grub.cfg, zfs entries.

[rlaager]

The issue with the "[: 68: missing ]" error is this line in /etc/grub.d/10_linux:
if [ "x${LINUX_ROOT_FS}" = xbtrfs || "x${LINUX_ROOT_STAT}" = xbtrfs ]; then

The fix is to change it to this:
if [ "x${LINUX_ROOT_FS}" = xbtrfs ] || [ "x${LINUX_ROOT_STAT}" = xbtrfs ]; then

[dajhorn]

I already fixed this in-tree as

if [ "x${LINUX_ROOT_FS}" = xbtrfs -o "x${LINUX_ROOT_STAT}" = xbtrfs ]; then

Let me double check whether I published it for all distro releases.

[rlaager]

Can this issue be closed?