Coder Social home page Coder Social logo

Comments (38)

aaassseee avatar aaassseee commented on August 24, 2024 2

Package has been released, please do a pub upgrade. Feel free to reopen or create new issues if you have any problems.

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024 1

The original code was a plugin so I didn't need to change it , also it works on windows 10 so I think there is something missing that crashes on windows 11

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024 1

still having the same crash even after updating to the last Visual Studio version as expected :

[√] Flutter (Channel stable, 3.3.4, on Microsoft Windows [version 10.0.22000.918], locale fr-FR) [√] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1) [√] Chrome - develop for the web [√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.5) [√] Android Studio (version 2021.2) [√] VS Code (version 1.72.0) [√] Connected device (3 available) [√] HTTP Host Availability

anyway, at least now we know that the issue is caused by screen_brightness and honestly I am not an expert on windows c++ development, i think it would be better to disable the brightness feature until the writer of the plugin makes a fix for it

i think this should work in your case

just add to your pubspec yaml that will overide to a screen_brightness without windows support

dependency_overrides:
  screen_brightness: "0.2.0"

from flutter_meedu_videoplayer.

aaassseee avatar aaassseee commented on August 24, 2024 1

Hi guys. I am the maintainer of screen_brightness. Is that all of the crash from this issue only happened on start up?
If so, can please try with the fix:

dependency_overrides:
  screen_brightness_windows:
    git:
      url: https://github.com/aaassseee/screen_brightness.git
      ref: develop
      path: screen_brightness_windows

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Does the examples work?

from flutter_meedu_videoplayer.

moghoneim-code avatar moghoneim-code commented on August 24, 2024

yes it works .. but when i add the package to a new project it doesn't

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Did you make the installation steps for dart vlc?

from flutter_meedu_videoplayer.

moghoneim-code avatar moghoneim-code commented on August 24, 2024

yes i did and i even copied the windows folder into my project but it didn't work .. note that i even reinstalled the c++ version in my device

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

yes i did and i even copied the windows folder into my project but it didn't work .. note that i even reinstalled the c++ version in my device

thats very weird, and you cant find any errors?

from flutter_meedu_videoplayer.

moghoneim-code avatar moghoneim-code commented on August 24, 2024

no errors in the console at all .. even i reinstalled android studio .. re run on vs code and still no solution

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

can you make a repo so i check your code?

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

please mention me when you do it, and will check it ASAP

from flutter_meedu_videoplayer.

moghoneim-code avatar moghoneim-code commented on August 24, 2024

ok i will create an example

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

@zezo357 I am having the same issue on windows the moment I add flutter_meedu_videoplayer to my pubspec.yaml my app will crash immediately.

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Can you try to add dartvlc package? Maybe it's the problem

And follow the initializing steps

I don't have the problem so I don't know

Also are you using windows 11? Maybe it's related to it

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

Can you try to add dartvlc package? Maybe it's the problem

And follow the initializing steps

I don't have the problem so I don't know

Also are you using windows 11? Maybe it's related to it

Yes, I am on Windows 11 but the example app works fine for me, I have tried to create a new flutter project with the last flutter version simply add flutter_meedu_videoplayer to pubspec.yaml will ends up with the same crash.
i will check dartVLC and let you know

Edit : adding dart_vlc: ^0.3.0 to my Project Will NOT cause any crash

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Will check why it crashes, looks like a missed step in the setup and didn't add it to my read me

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

Will check why it crashes, looks like a missed step in the setup, and didn't add it to my read me

well, I made a look at your work and I couldn't see any reason to publish the project as a Plugin (maybe I am missing something) instade I believe re_publishing the project as a package will solve the issue.

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

After a long investigation, it turns out that the crash was caused by screen_brightness for some reason that I don't know yet!

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

After a long investigation, it turns out that the crash was caused by screen_brightness for some reason that I don't know yet!

just tested new project with the package and didnt crash

can you make a repo for the one that crashes?

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

I just tested on windows 10 and I had no crash, I can confirm that the crash will happen only with windows 11 also removing
the brightness feature and screen_brightness plugin will solve the problem for windows 11 , but I didn't find why the example app works fine on windows 11

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Maybe the main cpp file is different?

from flutter_meedu_videoplayer.

moghoneim-code avatar moghoneim-code commented on August 24, 2024

Hi , please note the problem happen with windows 10 also .. if you looked at my screenshot above you will notice it is windows 10 . So if any one knows why it happen i will be very grateful

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Please make a repo with your code so I can check why it happens, since I can't reproduce it

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

Maybe the main cpp file is different?

I am pretty sure that there was no difference also i just made a new clean project example that has only flutter_meedu_videoplayer on pubspec and that will cause the app to crash immediately at the start

repo link

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Maybe the main cpp file is different?

I am pretty sure that there was no difference also i just made a new clean project example that has only flutter_meedu_videoplayer on pubspec and that will cause the app to crash immediately at the start

repo link

it works in my case
image
maybe because of flutter version ? i am running flutter 3.3.3

can you guys post your flutter doctor output

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

image

`[√] Flutter (Channel stable, 3.3.4, on Microsoft Windows [version 10.0.22000.918], locale fr-FR)
Checking Android licenses is taking an unexpectedly long time...[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.19)
[√] Android Studio (version 2021.2)
[√] VS Code (version 1.72.0)
[√] Connected device (3 available)
[√] HTTP Host Availability

• No issues found!`

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

@moghoneim-code can you share your flutter doctor, please?

from flutter_meedu_videoplayer.

moghoneim-code avatar moghoneim-code commented on August 24, 2024

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.3.2, on Microsoft Windows [Version 10.0.19043.2006], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.2.1)
[√] Android Studio (version 2021.3)
[√] VS Code (version 1.71.2)
[√] Connected device (3 available)
[√] HTTP Host Availability

• No issues found!

image

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

[√] Flutter (Channel stable, 3.3.4, on Microsoft Windows [Version 10.0.19043.2006], locale en-US)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc2)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.2)
[√] Android Studio (version 2021.2)
[√] IntelliJ IDEA Community Edition (version 2021.3)
[√] VS Code, 64-bit edition (version 1.71.2)
[√] Connected device (3 available)
! Device emulator-5554 is offline.
[√] HTTP Host Availability

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Visual Studio Community version?

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

Visual Studio Community version?

i really doubt about it but i will do some tests with the version that you are using

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Visual Studio Community version?

i really doubt about it but i will do some tests with the version that you are using

Will wait for you since I really can't find the problem

from flutter_meedu_videoplayer.

ledao avatar ledao commented on August 24, 2024

I have the same problem both in win10 and win11.
It seems something go wrong in screen brightness plugin. I just comment line 127, 146-153 in screen_brightness_windows_plugin.cpp (screen_brightness_windows_plugin project in runner solution), the abort disapears.
it's GetMonitorBrightness function, I do not know why.

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

I have the same problem both in win10 and win11.
It seems something go wrong in screen brightness plugin. I just comment line 127, 146-153 in screen_brightness_windows_plugin.cpp (screen_brightness_windows_plugin project in runner solution), the abort disapears.
it's GetMonitorBrightness function, I do not know why.

Can you post the issue in the screen brightness plugin? To make sure if the original issuer can fix it

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

still having the same crash even after updating to the last Visual Studio version as expected :

[√] Flutter (Channel stable, 3.3.4, on Microsoft Windows [version 10.0.22000.918], locale fr-FR)
[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.5)
[√] Android Studio (version 2021.2)
[√] VS Code (version 1.72.0)
[√] Connected device (3 available)
[√] HTTP Host Availability

anyway, at least now we know that the issue is caused by screen_brightness and honestly I am not an expert on windows c++ development, i think it would be better to disable the brightness feature until the writer of the plugin makes a fix for it

from flutter_meedu_videoplayer.

UnluckyY1 avatar UnluckyY1 commented on August 24, 2024

actually it should be :

dependency_overrides:
  screen_brightness: "0.1.4"

from flutter_meedu_videoplayer.

abdelaziz-mahdy avatar abdelaziz-mahdy commented on August 24, 2024

Package has been released, please do a pub upgrade. Feel free to reopen or create new issues if you have any problems.

Thank you ❤️, hope this fixes the problem for the ones who had it

from flutter_meedu_videoplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.