[win32] Zettlr not quitting when all windows are closed and the taskbar setting is off about zettlr

[nathanlesage]

@ejm554 @yonojoy I didn't mean "pin to taskbar", but rather that it keeps running in the status bar when all windows are closed (the small Zettlr icon in the area next to the windows clock).

The reason is that it will keep the unsaved changes in memory for as long as it runs.

But yes, it could very well be a bug. I'll definitely get back to this issue soon. In the meantime, feel free to try out the nightlies — they still need to go through a bit of betatesting, but I feel at least confident when it comes to the saving procedure. This would help me streamline my efforts going forward; this issue is top priority right now.

[boring-cyborg]

Thanks so much for opening up your first issue here on the repository! 🎉
We would like to warmly welcome you to the community behind the app! ☺️
We'll check in soon and have a look at your issue. In the meantime, you can
check your issue and make sure it aligns with our contribution guidelines!
Here's the comprehensive list:

NOTE: Please do not share screen captures of buggy behavior on YouTube.
If you have uploaded a video on YouTube and linked it already, don't
worry! But, we would like to ask you to remove the video from YouTube
and upload it directly to GitHub instead, by editing your comment.
Read more here.

Enhancements

An enhancement takes a feature and improves or alters its behaviour. Please
make sure to argue how your proposition will aid non-technical text workers,
and why it can't be emulated easily with other features or apps!

Feature requests

Feature requests introduce whole new features into the app. This requires a
lot of work, so these might be turned down if the implementation costs
supersede the benefits we expect to see from implementing it. Please do not
be disappointed if that happens. It likely has nothing to do with your great
request but simply with us and our missing resources!

You can of course always ask someone to implement this feature, because a PR
with a working new feature has much higher chances of being merged! :)

Bug reports

Please note that one of the main reasons for why bug reports cannot be
addressed is that there's not enough information for us to find and fix the
bug you describe, so make sure you try to pinpoint the bug as close as
possible.

The ideal bug report for us has two qualities:

1. The bug is always reproducible, at least within a certain context.
2. We know exactly what specifically goes wrong, and there is consensus on
   what should happen instead.

Please note that if you encounter behaviour that does not align with your
expectations of what would happen, this might as well be simply intended
behaviour and we need to simply clarify why the behaviour is the way it is.
This is not to be considered a bug and such issues may be closed! Suggest an
enhancement instead!

But now, have a great day and thank you again!

[nathanlesage]

A potentially very stupid question ... but ... do you have set Zettlr to remain in the taskbar? Is there a Zettlr icon when you close this window? Or does "with the mouse" mean to click on the corresponding menu item to quit (!) Zettlr?

[ejm554]

I just downloaded and tried your app for the first time today, and I ran into an issue similar to this bug. Briefly, I edited a Markdown file, closed it without seeing a Save option. Upon reopening, my changes weren't saved.

nathanlesage wrote:

... do you have set Zettlr to remain in the taskbar?

As a matter of fact, I did pin the Zettlr icon to the taskbar. Why do you ask? Could it be related to the bug?

[yonojoy]

I try to use Zettlr as my primary Markdown editor (previously I was using https://cloose.github.io/CuteMarkEd/). I have several Markdown files spotted over several folders. My normal workflow is this: I double click a md file and Zettlr opens. I read/edit it, then I close Zettlr. (The workspace / export functionality is only a gimmick for me).

Regarding your question. Do you mean if I right clicked on the Windows task bar icon for Zettlr and selected "Pin to Task Bar"? No.

Here are my Zettlr settings, that might have an influence:

• Always load remote changes to the current file: Off
• Avoid opening files in new tabs if possible: Off
• File Manager Mode: Combined
• Leave app running in the notification area: Off

Isn't this reproducable on your side?

[yonojoy]

@nathanlesage

* Leave app running in the notification area: Off

Do you mean this setting? It was off.

[nathanlesage]

Thanks for confirming. I'm back to the office and have access to a Windows PC now. I'll have a look if I can reproduce the issue!

[nathanlesage]

I have now reproduced the bug. It is that Zettlr is, interestingly enough, not quitting when all windows have been closed. I'll adapt the title to reflect that.

[yonojoy]

Given this:

I have now reproduced the bug. It is that Zettlr is, interestingly enough, not quitting when all windows have been closed. I'll adapt the title to reflect that.

and this

If I should bet, I would bet that this broken Zettlr state, when MainUI is gone, but processes still sitting around, is responsible for some of the "save bugs" that were reported under issues.

Turning the setting

Leave app running in the notification area

to On might be a workaround for several bugs "save bugs" that were reported under issues until a fix is available (?)

[nathanlesage]

to On might be a workaround for several bugs "save bugs" that were reported under issues until a fix is available (?)

I wouldn't bet on this. But I can tell you that by explicitly quitting the app by using the menu item or pressing Ctrl+Q, Zettlr will ask for confirmation so you don't have any lost changes. So I recommend for the time being to always explicitly quit, not just closing the window.

[yonojoy]

@nathanlesage

to On might be a workaround for several bugs "save bugs" that were reported under issues until a fix is available (?)

I wouldn't bet on this. But I can tell you that by explicitly quitting the app by using the menu item or pressing Ctrl+Q, Zettlr will ask for confirmation so you don't have any lost changes. So I recommend for the time being to always explicitly quit, not just closing the window.

I can confirm this;
I turned on the following setting:

Leave app running in the notification area

but nevertheless lost my data, because I forgot to close via the system menu.

[nathanlesage]

@nathanlesage

to On might be a workaround for several bugs "save bugs" that were reported under issues until a fix is available (?)

I wouldn't bet on this. But I can tell you that by explicitly quitting the app by using the menu item or pressing Ctrl+Q, Zettlr will ask for confirmation so you don't have any lost changes. So I recommend for the time being to always explicitly quit, not just closing the window.

I can confirm this;

I turned on the following setting:

Leave app running in the notification area

but nevertheless lost my data, because I forgot to close via the system menu.

That's a good observation, since the corresponding events won't be emitted by windows in that case ... I'll have to think about it, but you're right.