Comments (1)
Turns out the bug is something related to specifically play, and how PlayerManager decides which message object it's meant to reply to. Ran into it yesterday when doing testing with insert.
Currently, only the play command declares which message is replied to (PlayerManager.message = event;
, who thought this was a good idea to store the message??). This means anything else that triggers a sendembed track loading (or just 2 very closely timed play commands (this means this is a potential cross-server issue!)) would load correctly but reply to the wrong message. See image attached below, where insert at an index more than queue size causes a standard load.
Solution: Either pass the event to loadAndPlay (probably worth doing this as a replacement for the guild channel variable, since then we don't add even more args) or not use 1 variable for every single reply we ever intend to do
from gigavibe-java-edition.
Related Issues (20)
- /play File voids the messsage HOT 2
- forceskip and skip dont work well with loopqueue. HOT 1
- Queue command doesn't reply to the invoking message HOT 1
- Insert command voids songs in the queue and doesnt insert at the right index HOT 1
- Should clearqueue stop the current song from playing? HOT 3
- Potential better handling method for slash commands HOT 3
- Prevent radio from kidnapping the bot
- Bot gives no response when lacking voice channel connect perms HOT 1
- Insert command can be used despite the bot not being in the voice channel
- Fix and rework autoplay HOT 2
- Actively dispose of temporary files HOT 1
- add mitigation for 400s when playing a track. HOT 2
- Add regex precompilation HOT 1
- Investigate why tracks refuse to transmit audio in guild after the bot is running for some time HOT 1
- Implement auto-deletion of old logs
- Logger/stdout arent ordered correctly sometimes. HOT 3
- embeds with radios show "Unknown Title".
- Spotify spams logs.
- Log errors aren't perfectly timestamp formatted HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gigavibe-java-edition.