Coder Social home page Coder Social logo

suggested additions to Polynomial about curv HOT 2 OPEN

omershlo avatar omershlo commented on June 20, 2024
suggested additions to Polynomial

from curv.

Comments (2)

survived avatar survived commented on June 20, 2024

Great suggestions, @omershlo!

  1. Polynomial multiplication could be easily added. I assume FFT is not difficult to implement.
  2. What if I expose this method:
    impl<E> Polynomial<E> { 
        pub fn coefficients_mut(&mut self) -> &mut [Scalar<E>] { ... }
    }
    Would this allow to achieve what you want? Basically, you can sample a random polynomial Polynomial::sample_exact(), and then you can overwrite its coefficients, eg. : polynomial.coefficients_mut()[3] = Scalar::from(4)
  3. That's a reasonable suggestion. To allow construction from bigints, I would change from_coefficients constructor to be:
    impl<E> Polynomial<E> { 
        pub fn from_coefficients<S>(coefficients: impl IntoIterator<Item = S>) -> Self
        where Scalar<E>: From<S>
        { ... }
    }
    So this method will work with both Vec<Scalar<E>> and Vec<Bigint>. But this changes public API and requires major version bump. For now, it may be sufficient to add constructor from_bigint_coefficients that takes Vec<Bigint>.

from curv.

omershlo avatar omershlo commented on June 20, 2024

more:

  • return a coefficient in a specific index
  • trim leading zero coefficients
  • compute a % b for a, b polynomials
  • compute polynomial division

from curv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.