Allow for Player Faces to be a part of Global Settings, similar to Player Photos about zengm

[dumbmatter]

Currently I believe it uses the URL if present, and the face otherwise. No need to change that here unless that behavior is a problem. Cause if real player photos is Record<string, string | Face> then it's only one of the two that will be added - but if it's a Face you would need to delete any existing imgURL so it doesn't get overridden.

[dumbmatter]

It's a good idea.

Player photos is currently (in TypeScript terms) Record<string, string> but instead it could be Record<string, string | Face>, to support either URLs or face objects, or even both mixed together. typeof x === "string" can distinguish if it's a URL (string) or a face (object).

I think basically the only part of code that'd need to change is

zengm/src/worker/core/league/processPlayerNewLeague.ts

Lines 29 to 41 in aa859e9

	if (realPlayerPhotos[p.srID] !== undefined) {
	p.imgURL = realPlayerPhotos[p.srID];
	} else {
	const name = p.name ?? `${p.firstName} ${p.lastName}`;
	// Keep in sync with bbgm-rosters
	const key = `dp_${p.draft.year}_${name
	.replace(/ /g, "_")
	.toLowerCase()}`;
	if (realPlayerPhotos[key] !== undefined) {
	p.imgURL = realPlayerPhotos[key];
	}
	}

- check if the player's photo entry is a string or an object, and then update both p.imgURL and p.face.

Please feel free to give it a shot!

[tomkennedy22]

Cool, I'll take a look.
Do you have an opinion on the scenario: if a player has both photo URL & and face JSON present in player profile, which to use? In the game currently, users can decide in player profiles, just wanted to see if you would prefer a default.