Injection in abstract class constructor about zendframework

[zfbot]

(Originally posted by: EvanDotPro on 03/07/12)

Confirmed this works with setter injection but not constructor injection as of dd359a2.

[zfbot]

(Originally posted by: maks3w on 08/28/12)

Still happening

[zfbot]

This issue was ported from the ZF2 Jira Issue Tracker at
http://framework.zend.com/issues/browse/ZF2-148

Known GitHub users mentioned in the original message or comment:
@hoochie-coochie, @weierophinney, @EvanDotPro, @Maks3w

[ThaDafinser]

@drdev or @Maks3w does is this still a valid bug?

[adamlundrigan]

I pulled down his example and ran it against develop and the same exception is thrown.
(I had to fix the autoloader and rename Zend\Di\Configuration to Zend\Di\Config to get it to run)

Fatal error: Uncaught exception 'Zend\Di\Exception\MissingPropertyException' with message 'Missing instance/object for parameter criteria for MovieApp\Finder::__construct' in zf2/library/Zend/Di/Di.php on line 826

Zend\Di\Exception\MissingPropertyException: Missing instance/object for parameter criteria for MovieApp\Finder::__construct in zf2/library/Zend/Di/Di.php on line 826

Call Stack:
    0.0005     233624   1. {main}() Zend_DI-Examples/example-20.php:0
    0.0132    1059288   2. Zend\Di\Di->get() Zend_DI-Examples/example-20.php:62
    0.0153    1218352   3. Zend\Di\Di->newInstance() zf2/library/Zend/Di/Di.php:227
    0.0155    1223752   4. Zend\Di\Di->createInstanceViaConstructor() zf2/library/Zend/Di/Di.php:278
    0.0155    1224200   5. Zend\Di\Di->resolveMethodParameters() zf2/library/Zend/Di/Di.php:446
    0.0156    1228616   6. Zend\Di\Di->get() zf2/library/Zend/Di/Di.php:783
    0.0159    1232072   7. Zend\Di\Di->newInstance() zf2/library/Zend/Di/Di.php:227
    0.0160    1233360   8. Zend\Di\Di->createInstanceViaConstructor() zf2/library/Zend/Di/Di.php:278
    0.0160    1233640   9. Zend\Di\Di->resolveMethodParameters() zf2/library/Zend/Di/Di.php:446

I haven't spent any time in the Di component so I can't speak to whether it should be fixed or not. Perhaps @Ocramius or @ralphschindler could take a look?

[ralphschindler]

If you change your config to the following:

    $config = new Zend\Di\Config(array(
        'instance' => array(
            'alias' => array(
                'title-finder' => 'MovieApp\Finder',
            ),
            'MovieApp\Lister' => array( // <--- here don't bind the parameter to the Abstract, only the concrete
                'parameters' => array(
                    // Use configured finder
                    'finder' => 'title-finder'
                ),
            ),
            'title-finder' => array(
                'parameters' => array(
                    'criteria' => 'title'
                ),
            ),
        ),
        'definition' => array(
            'class' => array(
                'MovieApp\AbstractLister' => array(
                    'parameters' => array(
                        'criteria' => array('required' => true),
                    ),
                ),
            ),
        ),
    ));

it will work.

[ralphschindler]

I am inclined to close this.