Comments (7)
From @samsonasik on April 2, 2015 6:10
I'm 👍 for it. We can eliminate the .php_cs and php-cs-fixer call in .travis.yml then, right?
from component-split.
From @samsonasik on April 2, 2015 6:13
the drawback for it is we still can't exclude folder based on this discussion https://blog.styleci.io/redefining-configuration/#comment-1922515343
from component-split.
From @gianarb on April 2, 2015 7:25
Yes but in my opinion this proposal would become more specific, maybe we can extends this flow for other check.. Orchestration of components for the future is a very interesting argument
from component-split.
The requirements for the CS tool are two.
- Alert from CS violations
- Provide fix for the CS violation
We want a tool which help the developer to fix the CS violations.
from component-split.
From @gianarb on April 2, 2015 9:43
If you are one or more important PRs maybe you can merge a lot of them and
after this process you can apply a CS fix..
I don't know in my opinion this type of check require a different signal :)
But it's my opinion
from component-split.
From @gianarb on April 2, 2015 10:41
StyleCI or other server-ci is a very big step maybe in this moment it's too demanding but we can starting from zendframework/coding-standard project to centralize configuration
from component-split.
@Maks3w The nice part about php-cs-fixer
and phpcs
is that they each include tools that allow the developer to fix the majority of problems. This means that they can proactively use the tool to ensure the build passes, or, after a failed build, run the tool to correct the issues.
My personal preference is phpcs, as it covers the entire spectrum of PSR-1 and PSR-2, as well as has relatively easy methods for customizing sniffs. However, the php-cs-fixer lead has been very pro-active in assisting with our project, which has been the deciding factor so far in the use of that particular tool.
We can re-evaluate which tool we'll use after the components are split.
from component-split.
Related Issues (11)
- try split "Authentication" component got Invalid component name 'Authentication' HOT 17
- error : PHP Warning: copy(/home/vagrant/component-split/TestConfiguration.php.travis): failed to open stream: HOT 4
- composer install on splitted "Stdlib" error HOT 2
- How about zendframework/zend-resources HOT 5
- Split testing HOT 6
- Composer keywords array is duplicated
- Adopt this way of turn on/off checks on Travis-CI HOT 1
- zend-* version in composer.json's require and require-dev HOT 1
- History is duplicated master branch and tags have duplicated commits HOT 7
- Things to do before 2.5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from component-split.