Coder Social home page Coder Social logo

Comments (4)

akshayi1 avatar akshayi1 commented on June 17, 2024

Not sure if this was the right way to fix it, but made the following changes to ColumnDef.java and FloatColumnDef.java.

ColumnDef.java:

case "float":
case "real":
case "double":
        return new FloatColumnDef(tableName, name, type, pos);

FloatColumnDef.java

public boolean matchesMysqlType(int type) {
        if ( getType().equals("float") || getType().equals("real"))
            return type == MySQLConstants.TYPE_FLOAT;
        else
            return type == MySQLConstants.TYPE_DOUBLE;
    }

It seems to solve the problem and Maxwell accepts it without a hitch. Not sure about best practices though. Please take a look and see if this is a suitable solution.

from maxwell.

osheroff avatar osheroff commented on June 17, 2024

looks fine, can you do this as a PR (with a test) & I'll merge it?

from maxwell.

akshayi1 avatar akshayi1 commented on June 17, 2024

I have no idea of how to do that. Sorry :(

from maxwell.

akshayi1 avatar akshayi1 commented on June 17, 2024

#68 fixes this. Thanks!

from maxwell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.