Packaging Plugins creates RPMs with File Conflicts about cmake

[ckreibich]

Great write-up, thank you. Your fix looks right to me from the plugin's perspective, but I wonder whether other things will now break given that Zeek itself also uses ConfigurePackaging, and something should establish those directories. So we may need a way to distinguish the two uses, for example by relying on the fact that a plugin's cmake setup will source ZeekPlugin. @0xxon likely knows this area best.

Also, I understand zkg is the way forward, but zkg is exclusively source focused requiring you to build source plugins on the target system (unless things have changed, bundle just tars up the source repos).

Yeah. Plus, we will keep supporting Zeek plugins (as opposed to Zeek packages that happen to include a plugin) as standalone entities. Some folks among our user base already package up their plugins as RPMs. They likely aren't using our binary packages, though, so this problem hasn't come up before.

[0xxon]

The packages that we provide actually don't use make package - I don't think we actively have used this for years. We instead manually create rpms/debs.

So - I actually have no clue about this part of the build system - it probably is not super well tested :)

[ckreibich]

And I have to admit I had no idea we have RPM-tailored content in our cmake setup. :-) The above PR keeps your approach, @Mraoul, and just guards it so it only kicks in when we're building a dynamic plugin.

[Mraoul]

The packaging setup code has been part of the plugin skeleton for a very long time and is being carried over into the zkg package template, but I wonder if I'm the only one who uses that functionality ^_^. I applied the diff/patch from #32 to my local install (still 4.0.1) and it worked as expected, so that looks like a fix to me.

Thanks!

[ckreibich]

I've bumped cmake in Zeek itself, since it installs the cmake modules. I've not bumped the cmake submodules in the various other repos, since it shouldn't make any difference for them. Holler if I'm overlooking something.