Coder Social home page Coder Social logo

Comments (4)

mikkeloscar avatar mikkeloscar commented on June 19, 2024 1

This is a problem I never considered, but I can totally see how it's not ideal to have the same query name used.

I would consider it a feature that we change/extend the metrics definition in a way where you can name the metrics in a custom way. In the past we were limited to the metricName as an identifier because we were using older autoscaling API versions, but now with autoscaling/v2beta2 being the default we can take advantage of labels on all the metrics.

I would propose we add something like type: prometheus-query as a label and then let users define a custom metric.name.

from kube-metrics-adapter.

prageethw avatar prageethw commented on June 19, 2024

Thanks @mikkeloscar

from kube-metrics-adapter.

prageethw avatar prageethw commented on June 19, 2024

@mikkeloscar any idea whether this feature will be done at all?

from kube-metrics-adapter.

mikkeloscar avatar mikkeloscar commented on June 19, 2024

@prageethw I have it on my todo list, but didn't get around to implement it yet unfortunately. It's not forgotten but will take some time before I get around to it. Will also happily review PRs adding support :)

from kube-metrics-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.