Auto replace text when using Unikey. about vscode-markdown

[MagicPro1994]

After checking, I found that Unikey used Backspace. There was a conflict between your extension and Unikey.
I'm trying to fix my own problem. If I could solve them, I will give you a pull as a patch for those who use Unikey.

[yzhang-gh]

That's really strange.

I don't know Unikey but I guess it automatically replaces Mo65t with Một when you are typing. Since Mo65t was replaced to Mot in your case, I think Unikey did do its operation but there is something wrong.

As for the extension, it will listen to Enter, Tab and Escape keys and will do some different operations when you are editing Markdown list. Are you using this keys?

[MagicPro1994]

Thanks for you information.
I will check it on my Laptop then feedback to you.

[MagicPro1994]

@neilsustc
I solved my problem but it didn't work at all cases.
If I typed "Mo65t", it works well. But when I typed "Mot65", it doesn't work.

By the way, do you know how to extend Default Key Handler?
For example:
if (something) {
doCustomFunction();
} else {
callDefaultHandler();
}

[yzhang-gh]

If you are talking about vscode key handler, it can be override by add new keyboard shortcuts which execute your code.

if (your condition) {
    // your code here
} else {
    // default behavior
}

[yzhang-gh]

Here is where I override the default backspace key.

It will execute these code.

[MagicPro1994]

@neilsustc : No, I want to ask to use the default handler.
If you disable all extension, when you press backspace, the default handler will be executed.
Command "deleteLeft" is just a case of the default handler. That's the reason why I can use Unikey by disabling your extension.

[yzhang-gh]

Okay, that is the problem.

But according to vscode doc, I think deleteLeft should be the default handler. Maybe we should report this to vscode?

[yzhang-gh]

The only one "backspace" in the default keybindings

[MagicPro1994]

@neilsustc When I press "backspace", it delete 4 spaces. But when I use "deleteLeft", it just delete one space. I think we should report to VSCode. (In MacOS only, In Windows, OK).
As I know, VSCode solved the problem of Vietnamese Input a year ago.

[yzhang-gh]

Have you ever tried to change the onBackspaceKey function to only execute deleteLeft, I mean

function onBackspaceKey() {
    return commands.executeCommand('deleteLeft');
}

And then test whether the problem is still there?

[MagicPro1994]

Yes, there it is.
"Thien Ha Dai Su" should be replaced "Thiên Hạ Đại Sự"

[MagicPro1994]

Fixed but still has some minor bugs (typing fast).

[yzhang-gh]

I have to disable you handler, because https://github.com/neilsustc/vscode-markdown/blob/master/src/unikeyHandler.ts#L15-L16 results this

[MagicPro1994]

@neilsustc Ok. I have another way to solve my problem. I just need change key "Backspace" to "Shift+Backspace" or "Alt+Backspace". No need to modify the code.

[yzhang-gh]

Good to hear that

[Lemmingh]

This is now tracked at #200
Thank you again.