Extension Does Nothing about vscode-markdown

[rbolsius]

Yeah, that sounds good to me also since it will just look for README.md in the root folder. I tried it with my large project and workspaceContains:README.md performs well unlike the previous *.md event.

[yzhang-gh]

Thanks for your feedback. It is a known issue if you only open a single Markdown file.

It is a critical bug and I will resolve it soon.

[yzhang-gh]

Please try v0.7.6

[gpresland]

Please try v0.7.6

Same issue; VS Code handles md files as if the extension wasn't installed.

[yzhang-gh]

That's really strange 🤔.

Could you please describe how you open a md file? For example, do you

• With no vscode instance running, right click md file and select "open with vscode"? Or
• Use "open file" with existing vscode instance?

If possible, can you upload your md file (or a sample file for test).

[yzhang-gh]

Okay, finally I decide to go back to legacy activation events. There should be no problem now.

[rbolsius]

I was also going to suggest just switching to a simple "onLanguage:markdown" activation event. It seems like this is the best event to use to activate the extension since it doesn't perform any expensive file scans over the project and it is possible to enable the extension even when creating a new markdown file that has not been saved yet. Another benefit is that the extension will be activated regardless what extension the user chooses for the markdown files.

It seems like the "onLanguage:markdown" event may be the only event that is needed. I'm not sure if the "workspaceContains:README.md" event is necessary since the "onLanguage:markdown" event should occur whenever the README.md file (or any other markdown file) is opened.

[yzhang-gh]

@rbolsius Thanks a lot for your suggestions! You are really nice ❤

... just switching to a simple "onLanguage:markdown" activation event ... it is possible to enable the extension even when creating a new markdown file that has not been saved yet.

Yes. Totally agree. And that's why I finally gave up writing my own activation events 😅.

I'm not sure if the"workspaceContains:README.md"event is necessary

From the perspective of usage, I think it's not necessary.
But there is a (slightly?) noticeable delay when user open a Markdown file for the first time.
I use README.md because I would like to provide the best experience.
And adding an additional README.md won't hurt the performance because it only scans the depth 1 (but *.md will #12). So I think README.md is the icing on the cake. What is your opinion?

[yzhang-gh]

@gpresland Hope you like this solution.

[gpresland]

Appears to be working now 👍

[JackHowa]

This seems to be a problem for me. I'm not using README.md. Looking for the onLanguage:markdown activation setting.

[yzhang-gh]

@JackHowa onLanguage:markdown is already one of the activation events. See https://github.com/neilsustc/vscode-markdown/blob/master/package.json#L26-L29

So there might be some other reasons if you find it not working. Could you please navigate to "menubar>help>toggle developer tools" and see whether there are something related.