Coder Social home page Coder Social logo

Comments (18)

yzhang-gh avatar yzhang-gh commented on July 22, 2024 2

To my knowledge, no new APIs 😔

I would suggest posting this "auto-closing" feature request to vscode (rather than API) because the Markdown preview feature is actually implemented by vscode. We have little control over it as an extension.

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024 1

I tried and as expected it is very unstable and annoying. You won't like it.

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024

That's what I have planned some time ago. 😄

snipaste_20170416_154121

In the long term, the preview behavior might change in future vscode version (e.g. the preview tab might be merged into the Markdown code tab).

And for now, I'll have a try and see if there is a temporary workaround.

from vscode-markdown.

jamesfancy avatar jamesfancy commented on July 22, 2024

Thank you @neilsustc

e.g. the preview tab might be merged into the Markdown code tab

Great news, I like that feature.

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024

You can find more details about that feature in #22068.

side-by-side preview inside one tab

But I think it will probably take a long time to finish. 😂


I've published v0.5.1 with a temporary solution.
If you switch to a non-Markdown file, it will close all editors in other editor groups (usually the preview tab is in group 2). So it will be OK if you always edit your files in group 1.
Hope you will like.

from vscode-markdown.

jamesfancy avatar jamesfancy commented on July 22, 2024

@neilsustc v0.5.1 is not strong. Sometime it kept preview editor and closed other editors. I think it should rollback to v0.5.0.

Then let's wait for improvement of markdown extention.

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024

Could you provide any reproduction steps?
If it's hard to solve, I will roll back to previous version as you suggested.

from vscode-markdown.

jamesfancy avatar jamesfancy commented on July 22, 2024

@neilsustc OK, the steps are simple.

  1. use vscode to open a folder as project
  2. open a .md file (enough big size such as 20KB), the preview editor is opened and rendering.
  3. open a non-md file such as package.json
  4. package.json editor and the md file editor are closed, and the preview pane is still kept.

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024

I'll rollback to v0.5.0 as there is another user that also found this bug.

from vscode-markdown.

sanjibukai avatar sanjibukai commented on July 22, 2024

Hello,
As I understand this feature is not yet developed...
Is there a workaround to get the preview closed when focus is lost?
I mean, when the preview is opened it has the same name (ex: Preview file.md), maybe searching for opened tab using that name could help..

BTW, thanks great plugin !

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024

To my knowledge, we can't. Because vscode doesn't provide API to close a editor by name/id.

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024

I can only find vscode commands like closeActiveEditor etc. So I cannot find a workaround for now...

image

from vscode-markdown.

sanjibukai avatar sanjibukai commented on July 22, 2024

Thanks for the reply...
I think that vscode can bring focus to a newly opened tab (the behavior when a markdown preview is shown), so can it be possible to bring momentarily focus to that tab based on the history of activated tab (or if not possible to track, with some caveat eg. limiting to one opened markdown preview) to close it immediately afterwards (maybe with a callback)?

from vscode-markdown.

yzhang-gh avatar yzhang-gh commented on July 22, 2024

I get your point now 😂. Yes, it's possible, but really dangerous 🤣.

from vscode-markdown.

LeBenLeBen avatar LeBenLeBen commented on July 22, 2024

This would be an awesome feature. Any chance the API changed since your last tentative? Maybe opening a feature request in https://github.com/microsoft/vscode otherwise?

from vscode-markdown.

Trass3r avatar Trass3r commented on July 22, 2024

I would suggest posting this "auto-closing" feature request to vscode (rather than API) because the Markdown preview feature is actually implemented by vscode.

Well they still haven't implemented auto-hide of the terminal after all those years and lots of votes, not a good sign 😅
microsoft/vscode#10952

from vscode-markdown.

Trass3r avatar Trass3r commented on July 22, 2024

Also if I drag an .md file into VSCode with other files already open it does enable the preview on the right but then immediately switches the editor back to the previous one. Has anyone else experienced this?

from vscode-markdown.

Lemmingh avatar Lemmingh commented on July 22, 2024

microsoft/vscode#66132

from vscode-markdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.