Coder Social home page Coder Social logo

Comments (4)

Yuvaleros avatar Yuvaleros commented on June 8, 2024

What would you think would be a good solution here? a property that receives a path? or maybe it should receive a Material UI icon component?

from material-ui-dropzone.

max-carroll avatar max-carroll commented on June 8, 2024

well you could have it passed in as a prop, and because you will want to set the classes on it you can probably pass those in as props using React.createElement

const icon = React.createElement(this.props.customIcon, { className: classes.uploadIconSize }); |

DropzoneArea.defaultProps = {
...
customIcon: CloudUploadIcon

and have the default props as CloudUploadIcon , just an idea,

This would also cater for a scenario for if they want to use and Svg Icon or a font awesome Icon,

from material-ui-dropzone.

panz3r avatar panz3r commented on June 8, 2024

Hi @max-carroll ,

Thanks for your suggestion, currently there's an open PR #110 implementing this feature as you suggested.

I'll review it as soon as possible.

from material-ui-dropzone.

max-carroll avatar max-carroll commented on June 8, 2024

Ahh I've already implemented it on my side, didn;t realise that 🤣, ill review

from material-ui-dropzone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.