Coder Social home page Coder Social logo

Comments (7)

Yuubari avatar Yuubari commented on July 16, 2024

It's not in the original KCV so it has to be re-implemented.

Moreover, the original implementation has some very bad design decisions related to “different sounds for different types of notifications” and I'm unsure whether these can be rectified.

from kancolleviewer.

Yuubari avatar Yuubari commented on July 16, 2024

Update on this: will probably be ready soon as an additional plug-in. It will only implement sound notifications, with “visible” tray/toast stuff provided by the original plug-in.

from kancolleviewer.

Kintok1 avatar Kintok1 commented on July 16, 2024

Good to know, looking forward to it.

from kancolleviewer.

Yuubari avatar Yuubari commented on July 16, 2024

It's basically ready but there's one issue: I don't remember whether the notification sound in 3.x ever overrode KCV's “mute audio” function.

I've implemented audio output part of the new plug-in with the exact same library and the exact same code, but it gets muted when KCV is muted. Is it the same on 3.x?

from kancolleviewer.

Yuubari avatar Yuubari commented on July 16, 2024

Feel free to test it out: AudibleNotifications 1.0. You have to configure it via Settings, Plugins, AudibleNotifications Settings (the small link in the Features line).

Note that as mentioned above, if you mute KCV using the mute button custom sounds will not play, however the default Windows ding will (when no custom sounds are found).

from kancolleviewer.

Kintok1 avatar Kintok1 commented on July 16, 2024

Haven't tested the custom ones, but the Windows ding works correctly like it used to, thanks!

As a note, the notifications in 3.x releases did play the Windows ding even if the game was muted by KCV's mute button.

from kancolleviewer.

Yuubari avatar Yuubari commented on July 16, 2024

Because it's the way life's meant to be.

The ding is generated in the system notifications audio session which is system-wide and independent from application audio sessions like KCV's. Sadly, there is no way to access this audio session to play arbitrary audio streams aside from using a very old API call (PlaySound) that only supports 16-bit PCM RIFF WAVE files and has some issues, too.

This plug-in will be included with KCV, starting with next build.

from kancolleviewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.