Comments (4)
That's nice, would like to see any modifications and improvements!
from node-watch.
I'm realizing it was already in my fork. There is no explicit mention of close in the source code but you can now say.
var watch = watchFile('somepath',somecallback);
...
watch.close();
Here's a review of what it does. jvonmitchell@22e5936#diff-481962e7a473d9939d95e86648f023ee
All it does is expose the underlying listener so that you can close it. If any one wants to build a better return object that's ok with me. The idea is that the call to watch was exposing nothing so we might as well make it something.
One flaw with the way it is done is that it may return a listener or a [] so you have to watch for that. That's why there is a good argument for a better return object.
PS, yuanchuan: I want to apologize for writing something that may seem out of context. Someone emailed me asking for the updated code. I thought those emails were sent to me from this issue. Hence the sillyness. Feel free to use the changes I made.
from node-watch.
Ok. I now have a branch that returns an instance of an internal class that we can define behaviors for our return object in. I implemented close. More things could be implemented.
The branch is called returnObject.
from node-watch.
👍
from node-watch.
Related Issues (20)
- Follow symlink HOT 2
- watch dir bug HOT 2
- Calling close() before the watcher is ready does nothing HOT 2
- Avoid synchronous fs calls HOT 1
- Catch errors when adding watchers for child directories HOT 1
- Catch error when use Node 14.15.3 on Linux SysTem HOT 2
- I got this error at first use lib in nodejs using express HOT 2
- node-watch is not working recursive in Ubuntu under WSL HOT 5
- when watch a dir that mount by nfs, if not work HOT 2
- New ES syntax HOT 2
- Only pass skip on initial recurse
- Travis CI is no longer free, try to switch to GitHub CI
- Fix tests on Windows
- fs.watch() not detecting changes to file from git operation HOT 3
- images update problem HOT 3
- Can TEMP_DIR able to change ?
- linux and recursively with node 14 throws TypeError [ERR_FEATURE_UNAVAILABLE_ON_PLATFORM] HOT 1
- Add ignore option HOT 7
- multiple events for a file sent over network HOT 2
- High CPU consumption on window service HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-watch.