Coder Social home page Coder Social logo

Generate: val -> const val about buildkonfig HOT 7 CLOSED

yshrsmz avatar yshrsmz commented on May 30, 2024
Generate: val -> const val

from buildkonfig.

Comments (7)

Prototik avatar Prototik commented on May 30, 2024 1

@yshrsmz I found this: it allows const actuals for non-const expects
JetBrains/kotlin@b4c8544

from buildkonfig.

yshrsmz avatar yshrsmz commented on May 30, 2024

If I remember correctly, expect/actual cannot be used with const.
It's possible to use const when BuildKonfig generates a simple object(when you don't provide target-specific config) but to keep consistency between the 2 cases, I think we should stick to the current implementation

from buildkonfig.

yshrsmz avatar yshrsmz commented on May 30, 2024

I'm going to close this for now.
Feel free to reopen this if you find a way.

from buildkonfig.

Prototik avatar Prototik commented on May 30, 2024

@yshrsmz you can expose expect/actual const values with using @Suppress("CONST_VAL_WITHOUT_INITIALIZER") on the expect class.
I believe it's a bug in a compiler, and with this suppress i'm using it without any problems since kotlin 1.3.

from buildkonfig.

yshrsmz avatar yshrsmz commented on May 30, 2024

Hi @Prototik, thanks for the great information.

Do you know any source about this?

I found this youtrack issue, but it does not clarify if this is a bug or not
https://youtrack.jetbrains.com/issue/KT-18856/Can-we-have-expectactual-consts

from buildkonfig.

Prototik avatar Prototik commented on May 30, 2024

No, I don't have any additional information about this, i discovered it by myself via looking to source code of kotlin compiler. I think this inspection just don't care about expect/actuals and should not be forced on expect declrations (due to fact expect cannot have default implementation of any sort).

I personally used it in my own BuildConfig-like plugin for a couple years already and don't encounter any issues with this suppress, and i think it's generally safe to do that (at least with opt-in behavior as I suggested in #70).

from buildkonfig.

yshrsmz avatar yshrsmz commented on May 30, 2024

That's great!
Let's move it forward 💪

from buildkonfig.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.