Coder Social home page Coder Social logo

Comments (3)

MaxRenaud avatar MaxRenaud commented on June 12, 2024 1

Thanks for closing. I am not sure how you'd test it using your current testing methodology. If you want to refactor a bit, you can have a function that takes an io.Reader interface in your .go file. That way, you can decouple the file reading and the temperature parsing.

In your test, you can use strings.NewReader("Something") to create an an object that satisfies io.Reader and you can pass around.

As for the default value, I'm not sure if the w1 drivers override the read value when the CRC fails or if it puts puts the read value as is. I think your commit is doing the right thing by checking for a CRC match, then returning an error if it doesn't match.

from ds18b20.

yryz avatar yryz commented on June 12, 2024

@MaxRenaud
Is there a default value for t when CRC != YES?
This is easy to change. I want to test it. Can you tell me how to test it?
image

from ds18b20.

yryz avatar yryz commented on June 12, 2024

448a8e7

from ds18b20.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.