Coder Social home page Coder Social logo

Comments (3)

Yorko avatar Yorko commented on September 24, 2024

I don't see the point. Questions 3.6 and 3.7 are in total correspondence with the assignment.

from mlcourse.ai.

fralik avatar fralik commented on September 24, 2024

The point is that anyone who tries to do demo assignments now will get their answers marked incorrect. Despite the answers being correct. Take me: I did the assignment, checked my answers and then boom! Answers I gave to 3.6 and 3.7 were incorrect. But the questions are relatively straightforward. I triple-checked my code. I was still getting the same values, which were incorrect according to the web form.

I then went on and checked out a previous version of the assignment. Run my code (exactly the same code). Hey! I got the correct answers.

Now to wrap up. Possible answers to question 3.6 from the web form are: 0.895; 0.856; 0.788; 0.845.

Code with the answer to question 3.6 (corresponds to section 3.1 in the notebook)

tree = DecisionTreeClassifier(max_depth=3, random_state=17)
tree.fit(X_train, y_train)
tree_predictions = tree.predict(X_test)
accuracy_score(y_test, tree_predictions)

If one runs it in ed28f5f (current master), the result is 0.790.
If one runs it in 152a534 (previous version), the result is 0.845.

Please note how the answer from the previous version matches web form expectations.

So I am saying that although this is a demo assignment, the validation form doesn't validate answers of the current version of the assignment.

from mlcourse.ai.

Yorko avatar Yorko commented on September 24, 2024

fixed that in 4130b09

I've found the reason. Maybe it's a bug in sklearn implementation: accuracy depends on the order of columns. First categorical, then numeric features (1) or vice versa (2) - accuracy differs very much in (1) and (2). Now checked with docker, shall be all right.

Thanks!

from mlcourse.ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.