Comments (6)
This message seems to be guarded by resyncInterval
being enabled so I'm just disabling that option for now – it seems like the interval just needs to be cleared on socket close?
from y-websocket.
I was working with someone who reported (and showed logs) that the first sync message went missing. This would mean that in some browsers the first message on the websocket protocol can get lost which is very disturbing.
The issue seems to happen when a client connects through a VPN to a different region. It was only happening to a non-developer and I wanted to confirm what is happening.
I haven't head back from that user. So I will remove the message.
resyncInterval should fix the issue anyway. I'm not sure what else I can do.
from y-websocket.
Any truth in my observation that rsyncinterval should be cleared when the connection is closed?
from y-websocket.
When the connection is closed then then ws
object should be set to null (
y-websocket/src/y-websocket.js
Line 94 in 5a36d77
Then resyncInterval
shouldn't do anything anymore.. (
y-websocket/src/y-websocket.js
Line 222 in 5a36d77
So how do you have a closed connection and still have the resyncInterval send messages?
Do you overwrite the onclose property? Or is there an edge case I'm not aware of?
from y-websocket.
Not overwriting anything. It was happening during the retry connection loop once the server is killed, so there might be an edge-case – If I pin it down I'll file another ticket/PR.
from y-websocket.
That would be great, thanks!
from y-websocket.
Related Issues (20)
- Callback object content is empty
- Could not find a declaration file for module 'y-websocket' HOT 3
- Offline modus or pending connect
- Extraneous updates where origin == null when using full reload
- how to detect the server side ping message
- Websocket closes on tab minify/switch after +/- 30s. How to handle?
- Server-side reloaded ydoc version is getting overwritten by client-side version upon page refresh
- Missing doc data binding when refreshing the page
- the new heap suddenly increase HOT 3
- how can I stop y-websocket-server? HOT 1
- Version 1.5.2 breaks y-websocket in the browser HOT 4
- Can't get text data on server HOT 6
- WebSocket connection to 'wss://localhost:9999/' failed HOT 1
- Persistance directory HOT 1
- "type":"module" / SyntaxError: Cannot use import statement outside a module
- cannot connect to y-websocket with node HOT 1
- yrb-actioncable sync awareness
- In bin/utils.js, closeConn(..) doesn't handle correctly if persistence is null HOT 1
- npx y-websocket does not work HOT 1
- How to verify permissions in websocket
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from y-websocket.