Comments (5)
This looks like an int overflow is occurring, I'll check further.
from symusic.
Seems same problem occurred in mido
.
from symusic.
I found other MIDIs for which the resample
operation shifts some of their events to negative time values
midis.zip
They all have in common very large end
tick values.
To reproduce:
from pathlib import Path
from symusic import Score
paths = list(Path("midis").glob("**/*.mid"))
for path in paths:
score = Score(path)
score = score.resample(12, min_dur=1)
start_tick = score.start()
from symusic.
@Natooz This is an int overflow caused by improper multiplication order during resample.
I've adjusted the order of multiplication in the resample and these examples no longer overflow. But an inappropriate resample can still cause an overflow, so I've further added an overflow check to determine if the scaled time
is still valid.
from symusic.
Wonderful thank you!
from symusic.
Related Issues (20)
- [Question] Performance improvement compared to mido HOT 4
- Incorrect/inconsistent treatment of program change in dump_midi HOT 9
- Bug when multithreading with macOS since 0.3.4 HOT 14
- Unable to build on linux HOT 10
- Adding a function to easily modify the event times at a score level (like `midi.adjust_times` in PrettyMIDI) HOT 35
- Question and Request: Sorting after conversion to second HOT 5
- Inconsistency between the interface of vector bindings and python list & potential wild pointer problems. HOT 55
- merging tracks HOT 3
- Segmentation Fault when reading Score from MIDI files HOT 3
- Make `Score.clip` include the ongoing tempo/time signature/key signature at `start` HOT 7
- Inconsistency with Score when writing to Audio HOT 11
- MIDI files with simultaneous note on/off ticks result in incorrect note durations HOT 3
- nanobind v2.0.0 breaks building compatibility HOT 3
- nanobind problem HOT 7
- Suppression of Nanobind leak messages HOT 6
- Set-Tempo events not applied correctly to timestamps in multi-track files HOT 1
- MIDI message level interface design HOT 3
- Note durations in a midi file increase after loading and dumping via symusic.Score HOT 3
- Nanobind Issue HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from symusic.