Change FormModel::attributes as protected or add method like getAttributeNames about form

[Gerych1984]

If now explained in that way it makes sense, can you do the PR?

Yes, tomorrow morning - I'm at the phone now. Thanks

[terabytesoftw]

Can you give an example of what you want to do since collectAttributes() returns all the attributes of the formModel:

form/src/FormModel.php

Line 250 in ebf4532

return $attributes;

[Gerych1984]

Can you give an example of what you want to do since collectAttributes() returns all the attributes of the formModel:

form/src/FormModel.php

Line 250 in ebf4532

return $attributes;

My current realization (writed today) in abstract class AbstractSearchForm extends FormModel. I'm using this to send as data in Vue form component. Or store in DB - when user save selected filters to quick access in future

public function toArray(bool $hideEmpty = true): array
{
    $array = [];
    /**
     *I think need $this->attributes or sometihng like $this->getAttributeNames() instead of ReflctionClass/ReflectionProperty
    */
    $class = new ReflectionClass($this);
    $properties = $class->getProperties(ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_PUBLIC);

    foreach ($properties as $property) {
        if ($property->isStatic()) {
            continue;
        }

        $name = $property->getName();
        $value = $this->getAttributeValue($name);

        if ($value === null || is_scalar($value)) {
            if ($hideEmpty && ($value === '' || $value === null)) {
                continue;
            }

            $array[$name] = $value;
        } elseif (is_array($value)) {
            if ($hideEmpty && count($value) === 0) {
                continue;
            }

            $array[$name] = $value;
        } elseif ($value instanceof FormModel) {
            $nested = $value->toArray($hideEmpty);

            if ($hideEmpty && count($nested) === 0) {
                continue;
            }

            $array[$name] = $nested;
        }
    }

    return $array;
}

[terabytesoftw]

Can you give an example of what you want to do since collectAttributes() returns all the attributes of the formModel:

form/src/FormModel.php

Line 250 in ebf4532

return $attributes;

My current realization (writed today) in abstract class AbstractSearchForm extends FormModel. I'm using this to send as data in Vue form component. Or store in DB - when user save selected filters to quick access in future

public function toArray(bool $hideEmpty = true): array
{
    $array = [];
    /**
     *I think need $this->attributes or sometihng like $this->getAttributeNames() instead of ReflctionClass/ReflectionProperty
    */
    $class = new ReflectionClass($this);
    $properties = $class->getProperties(ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_PUBLIC);

    foreach ($properties as $property) {
        if ($property->isStatic()) {
            continue;
        }

        $name = $property->getName();
        $value = $this->getAttributeValue($name);

        if ($value === null || is_scalar($value)) {
            if ($hideEmpty && ($value === '' || $value === null)) {
                continue;
            }

            $array[$name] = $value;
        } elseif (is_array($value)) {
            if ($hideEmpty && count($value) === 0) {
                continue;
            }

            $array[$name] = $value;
        } elseif ($value instanceof FormModel) {
            $nested = $value->toArray($hideEmpty);

            if ($hideEmpty && count($nested) === 0) {
                continue;
            }

            $array[$name] = $nested;
        }
    }

    return $array;
}

Why do a getAttributes(), if calling collectAttributes() has the same attributes, i don't understand.

form/src/FormModel.php

Line 38 in ebf4532

$this->attributes = $this->collectAttributes();

[Gerych1984]

Why do a getAttributes(), if calling collectAttributes() has the same attributes, i don't understand.

form/src/FormModel.php

Line 38 in ebf4532

$this->attributes = $this->collectAttributes();

---

It will be call twice (or N times) and unnecessary recalculate attribute types just for get names. I can call collectAttributes in AbstractSearchModel::__construct, but for what? We already have this array, maybe just add method like in AR

public function attributes(): array
{  
    return array_keys($this->attributes);
}

[terabytesoftw]

Why do a getAttributes(), if calling collectAttributes() has the same attributes, i don't understand.

form/src/FormModel.php

Line 38 in ebf4532

$this->attributes = $this->collectAttributes();

It will be call twice (or N times) and unnecessary recalculate attribute types just for get names. I can call collectAttributes in AbstractSearchModel::__construct, but for what? We already have this array, maybe just add method like in AR

public function attributes(): array
{  
    return array_keys($this->attributes);
}

If now explained in that way it makes sense, can you do the PR?