OffsetPaginator may provide inconsistent data. about data

[samdark]

If the data source changes between the two operations

Do you mean something like deleting 100 records from SQL DB?

[kamarton]

Do you mean something like deleting 100 records from SQL DB?

yes.

• delete records
• update records (depend on filter)
• insert records

[kamarton]

May need to remove the PaginatorInterface::getCurrentPageSize() method from the interface. In this case, use this sequence:

$items = PaginatorInterface::read();
$currentPageSize = count($items);
// and more operate $items...

[roxblnfk]

If we will use count (OffsetPaginator::read()) in getCurrentPageSize(), then we should consider the following:

• A call to DataReaderInterface::count() occurs in other places (getTotalPages(), getTotalItems()). So desync is still possible in other places.
• The call to DataReaderInterface::count() anyway occurs in read(), in addition, DataReaderInterface::read() can work with the generator, so the call to count(OffsetPaginator::read()) to determine the number of elements may cause additional overhead

[samdark]

That is a drawback we are going to live with. Offset pagination if affected by data removal.