Contribution clarification about curl_cffi

[yifeikong]

You can export as many as you like, I don’t see any side effect here. Just make sure they are grouped in the correct category.

[yifeikong]

Yes, the const.py is generated by generate_consts.py. Actually, this file should be called when building the wheel to generate const.py, and const.py should not stay in the source. However, due to limitations on Windows, const.py is kept for convenience.

[nicoandmee]

Yes, the const.py is generated by generate_consts.py. Actually, this file should be called when building the wheel to generate const.py, and const.py should not stay in the source. However, due to limitations on Windows, const.py is kept for convenience.

Ah yes I got that. But I'm wondering, if there is more work to be done in generate_consts.py.. For example- You have a TODO mentioned referring to CURL_ERROR_SIZE. This declaration is inside curl.h:

#define CURL_ERROR_SIZE 256

It seems we can get it along with all other #define declarations, in this way:

cat '/usr/include/curl/curl.h' | grep -i "#define.*" | grep -i "CURL" | awk 'xor(/\s[0-9].*/,/<</)' | sed 's/\/\*\s*.*//'

Then I can add wrappers in generate_const.py, like a class CurlError(IntEnum), class CurlProto(IntEnum), etc accordingly. But I'm not sure if this is a good idea, so I'd like your opinion 😄