Failed patching of nginx.conf.web.https.template zimbra 8.8.8 about certbot-zimbra

[jjakob]

@maxxer of course, I'd be glad to help out. I've been thinking of replacing the patching approach with something more simple, like a sed script that just puts the new location block at the end of the file (before the closing curly brace). That should work across all the different versions. Once I have that ready I'll create a pull request.
@eN0Rm thanks, I've tested the patching part on my Zimbra installation and it works fine, so possibly you have a different version that changed the template files again. More on that at my repo.

[eN0Rm]

I'm closing this issue. Would be nice if you guys can join forces. I'll help out with testing in @jjakob repo, and then I guess he can create a pull request.

[jjakob]

Hi! Thanks for testing the script. I see issues weren't enabled on my fork, I've enabled them now.
Can you create this issue at jjakob/certbot-zimbra/issues?
After that it can be deleted here where it doesn't belong so we don't clog up YetOpen's own repo.

[maxxer]

Hi @jjakob. I wrote you an email about it, it would be great if we could join efforts and keep a single repo (possibly this one) for the project. I'm really lacking spare time lately to work on it, and it would be great to have some help. All the people relying on the script will benefit from having it fixed here.

You'll be of course credited for all your work. Please let me know what you think about it. Thanks

[maxxer]

if you need help with sed I'm not a big boss but we can find it out together. just let me know.

[eN0Rm]

I can convert it to sed, not a problem. It was more if the check "looking for the first } at the beginning of the line" is good enough. It could fail in multiple ways, but if you can assume that the config files are formated like that and not customized, it should work.

…

On Tue, Jun 5, 2018 at 10:20 AM, Lorenzo Milesi ***@***.***> wrote: if you need help with sed I'm not a big boss but we can find it out together. just let me know. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AChQteB_OEcfckadXTSHO5I-IdSzNxVZks5t5j9HgaJpZM4UU1XY> .

-- Mvh -fredrik-normann-

Sent from my Gmail Account

[eN0Rm]

Thought I was commenting on this issue https://github.com/jjakob/certbot-zimbra/issues/1 at @jjakob repository On Tue, Jun 5, 2018 at 11:00 AM, [email protected] < [email protected]> wrote:

…

I can convert it to sed, not a problem. It was more if the check "looking for the first } at the beginning of the line" is good enough. It could fail in multiple ways, but if you can assume that the config files are formated like that and not customized, it should work. On Tue, Jun 5, 2018 at 10:20 AM, Lorenzo Milesi ***@***.***> wrote: > if you need help with sed I'm not a big boss but we can find it out > together. just let me know. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#51 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AChQteB_OEcfckadXTSHO5I-IdSzNxVZks5t5j9HgaJpZM4UU1XY> > . > -- Mvh -fredrik-normann- Sent from my Gmail Account

-- Mvh -fredrik-normann-

Sent from my Gmail Account

[maxxer]

missed it thanks!!