hamlet allows slash in tag names about shakespeare

[snoyberg]

Good idea, patch applied.

[sol]

@snoyberg I guess I could construct other cases that produce undesirable results. I think the only sensible way to handle this is to follow the specs. I have a patch for this, that I'll push soon.

[snoyberg]

You mean like having sensible values for attribute names and such? I've taken the approach for the most part of "not our problem," but we may as well ensure validity at compile time since it's so easy. If you come up with any other cheap fixes, definitely send a pull request.

[sol]

@snoyberg It is a little bit more code, this is why I put it into a separate module. The layout and comments mean to make it easy to compare it with the spec. I do not use elem because this is an order of magnitude slower than expanding it.

[snoyberg]

I think what you've put in is too restricting. For example, some Javascript libraries out there use colons in tag names. Also, you could embed SVG in such a way.

I'm not sure what you mean by elem being an order of magnitude slower. It's going to cause the string to be traversed twice: once in the parse, and then afterwards in the check. The reason I did it with the elem was to give better error messages, and to keep the parser more consistent.

[sol]

@snoyberg Oh, that is unfortunate. I would still love to have better compile-time guarantees for well-formed content, but right now I've no idea how to tackle it.

Regarding elem: I had a situation where it made code 10x faster; I could imagine, that the main difference came from inlining. But better error messages are probably more important.

[snoyberg]

Another performance issue to point out is that this only affects compile time, not runtime. We all hate long compiles, but I doubt this is the bottleneck.