Wrong path reported for checkstyle errors about qulice

[yegor256]

migrated from Trac, where originally posted by yegor256 on 2-Nov-2011 8:47pm

Thanks for reporting!

[yegor256]

migrated from Trac, where originally posted by yegor256 on 3-Nov-2011 6:51am

Dzmitry, can you fix this defect? The budget is 1 hour.

Don't forget that first we should reproduce the problem with a unit/integration test. You should create some test that will fail with current implementation. Then you fix the defect and the test should pass.

[yegor256]

migrated from Trac, where originally posted by dpetruha on 4-Nov-2011 10:55pm

Hi Yegor!

As I think it is not pure checkstyle problem. I mean that any validator (checkstyle, PMD, etc) should log those errors correctly.

Moreover, I've noticed that CheckstyleValidator and PMDValidator have duplicated code for getting list of files to process (files(Environment)).

My point is that reporting errors to log should be done in single place (maybe even not validator responsibility).

So, if you have time lets discuss and decide how to implement and what and how to unit test. And of cause the budget if you are agree with the above)

[yegor256]

migrated from Trac, where originally posted by dpetruha on 4-Nov-2011 10:55pm

Yegor, please see my comment above

[yegor256]

migrated from Trac, where originally posted by yegor256 on 6-Nov-2011 7:06am

I totally agree with everything you said above. But keep in mind that we're solving "one problem per ticket" only. All your concerns/ideas should be reported in new tickets. For every ticket you report (if it's accepted) you will get 1/2 hours.

Thus, if you see that the project needs refactoring (or bug fix) before you can start working with this ticket - report a problem and wait until it's fixed. Once all of them are fixed - you get back to the ticket and finish it.

[yegor256]

migrated from Trac, where originally posted by yegor256 on 20-Nov-2011 6:48pm

Any news here?

[yegor256]

migrated from Trac, where originally posted by dpetruha on 24-Nov-2011 10:11am

CheckstyleValidator should be changed to implement com.qulice.spi.ResourceValidator. I.e.
a)CheckstyleValidator will be provided with file to validate
b)then it should make validation and do not log any errors but return ResourceValidationResult.
c)In case CheckstyleValidator is not interested in the resource then just return null.

Move CheckstyleValidator from com.qulice.maven.ValidatorsProvider.all() to com.qulice.maven.ValidatorsProvider method returning ResourceValidators list (be implemented as part of #44).

com.qulice.spi.ResourceValidator? will be implemented as part of #44.

[yegor256]

migrated from Trac, where originally posted by yegor256 on 24-Nov-2011 11:27am

Let's wait for #44

[yegor256]

migrated from Trac, where originally posted by yegor256 on 27-Nov-2011 12:53pm

Waiting for #44 and #61

[yegor256]

migrated from Trac, where originally posted by yegor256 on 22-Jan-2012 11:39pm

Milestone PROTOTYPE deleted

[yegor256]

migrated from Trac, where originally posted by yegor256 on 24-May-2012 1:14pm

let's do it in the next version

[yegor256]

migrated from Trac, where originally posted by yegor on 21-Apr-2013 12:03pm

we moved to Github

[yegor256]

no need any more