Coder Social home page Coder Social logo

Comments (6)

saltyfacu avatar saltyfacu commented on August 17, 2024

How does it work when you use it connected through Metamask? Does it have the expected behaviour?

from iearn-finance.

 avatar commented on August 17, 2024

Hi fameal. Same issue on metamask (though that is a problem on their side cause they also haven't updated to trezor connect 8 yet: MetaMask/metamask-extension#8349)

Take a look at myetherwallet, they use a connect version >= 8 and there it works fine. Same on synthetix.

from iearn-finance.

saltyfacu avatar saltyfacu commented on August 17, 2024

Yes, but we are using web3-react and they have not updated the trezor module.

from iearn-finance.

 avatar commented on August 17, 2024

I am not familiar with web-dev (doing backend only). tbh, I am not sure if I get this, can you explain further pls? The web3-react trezor connector (6.1.6: https://www.npmjs.com/package/@web3-react/trezor-connector) has trezor connect as a dependency. Our package-lock.json file has "@web3-react/trezor-connector" and trezor-connect version 7.0.5 hardcoded. When I install the app via npm install, it installs whatever is specified in package-lock.json right?

So why can't we just update the trezor-connect dependency to lets say 8.1.14 (the latest version)?
I actually tested this and changed this:

    "trezor-connect": {
      "version": "7.0.5",
      "resolved": "https://registry.npmjs.org/trezor-connect/-/trezor-connect-7.0.5.tgz",
      "integrity": "sha512-cGHcNuO/kGVF6b1mp5VB/RwXcXwqZJDPLp3opx7vM+BQ8xB4oDAUdL+T8aCKRbDv6HwP/wvGwoaok/+9kYOPfA==",
      "requires": {
        "@babel/runtime": "^7.3.1",
        "events": "^3.0.0",
        "whatwg-fetch": "^3.0.0"
      }

to (cp'd from here: https://github.com/MyEtherWallet/MyEtherWallet/blob/master/package-lock.json)

    "trezor-connect": {
      "version": "8.1.14",
      "resolved": "https://registry.npmjs.org/trezor-connect/-/trezor-connect-8.1.14.tgz",
      "integrity": "sha512-Y0yY7Mc8iN/feLct2bnJNEIbFbbMC+bCddQ7vMf22ygpcl/plNnvnze03mi6+7hEk3FmiR66gi12INSOr0wBHw==",
      "requires": {
        "@babel/runtime": "^7.11.0",
        "events": "^3.2.0",
        "whatwg-fetch": "^3.3.1"
      },

After installing it (I removed the previous installed node_modules) it is using trezor.io/8 instead of 7 and allows me to type in the passphrase via the device, which is exactly what I wanted.

Is there anything that I miss here? Thanks for looking into this! :)

from iearn-finance.

saltyfacu avatar saltyfacu commented on August 17, 2024

I'm testing that, but installing the package with npm. I will test it in a short while.

from iearn-finance.

 avatar commented on August 17, 2024

Just tried it on the mirrored y.finance site and works as expected :) Thanks for the upgrade guys! I am closing the issue.

from iearn-finance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.