Coder Social home page Coder Social logo

Comments (3)

tpunt avatar tpunt commented on June 4, 2024

At a quick glance, it looks as though the wg.Add(1) (on line 43) needs to happen outside of the goroutine creation in commit a654684 @yanue

from starkex.

tpunt avatar tpunt commented on June 4, 2024

Actually, I don't see how making the PedersenHash function concurrent like this could work anyway...

Also, the extended Euclidean algorithm implementation (igcdex()) looks broken. E.g. the first if statement is comparing the same conditions.

I've forked the project for now (tpunt/starkex) to apply the fixes, since the owner is not currently around. Happy to create PRs to fix things in this repo when the owner is back (I really don't want to maintain a fork of this).

from starkex.

emil14 avatar emil14 commented on June 4, 2024

Awesome! Thank you so much @tpunt

from starkex.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.