Comments (3)
At a quick glance, it looks as though the wg.Add(1)
(on line 43) needs to happen outside of the goroutine creation in commit a654684 @yanue
from starkex.
Actually, I don't see how making the PedersenHash
function concurrent like this could work anyway...
Also, the extended Euclidean algorithm implementation (igcdex()
) looks broken. E.g. the first if
statement is comparing the same conditions.
I've forked the project for now (tpunt/starkex) to apply the fixes, since the owner is not currently around. Happy to create PRs to fix things in this repo when the owner is back (I really don't want to maintain a fork of this).
from starkex.
Awesome! Thank you so much @tpunt
from starkex.
Related Issues (8)
- 关于签名里面的问题 HOT 1
- question about usage HOT 1
- Add more support for additional markets. HOT 1
- create new order 签名错误??? HOT 2
- Support for goerli network HOT 2
- 关于 order 签名的效率问题 HOT 2
- How to use the signature generator for dydx exchange ? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starkex.