Coder Social home page Coder Social logo

Comments (2)

yairm210 avatar yairm210 commented on July 17, 2024

Kotlin version - definitely yes

AGP version - we'll need to check
I prefer to stick to versions supported by IDEA as well as Android Studio, it has distinct advantages in e.g. performance profiling

from unciv.

SomeTroglodyte avatar SomeTroglodyte commented on July 17, 2024

Those versions are: AGP is exactly the one offered by Jellyfish-patch2 automatically - haven't upgraded to Koala yet, as usual not trusting it until it has a patch1. Gradle: that AGP plugin chooses 8.6 as new default - or rather needs 8.6 as minimum to install, but also has 8.8 in its offered list, so I chose that version manually - because auto won't upgrade everything, but that gradle wrapper call does include the wrapper jar itself. Why exactly I didn't choose 9 - the argument "too fresh, and might necessitate major build script updates" is already sufficient, but I think AGP didn't offer 9 yet too.

This was FYI so you know I did the experiment and it was relatively painless. I can redo it and wrap as PR - you decide when. But keep in mind all devs pulling that version will need a bit of local maintenance - the kotlin compiler version in settings (that val only determines kotlin-gradle-plugin and kotlin-reflect judging from Alt-F7), possibly a manual gradle sync, optional cache cleanup, one longer gradle sync than usual.

AGP 8.2 was november 2023, so we're not that far behind. We could even up the Compile SDK one level without changing AGP, only for the current preview we'd need more.

Also: Project structure - suggestions shows a few other libraries have newer versions: androidx.core:core-ktx, androidx.work:work-runtime-ktx and com.android.tools:desugar_jdk_libs - I did not test upgrading those, as I'm not really sure where one would see their effect, mostly the work runtime, the other two I'd expect are already tested when one can debug-run android.

For a real PR I would probably also check first whether Koala would go to a different AGP (8.5 is out, its release notes say yes Koala would use that one), then think hard on whether it would be preferable or not.

from unciv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.