"Costs [amount] [stockpiledResource]" doesn't appear to do anything about unciv

[SomeTroglodyte]

Check #11701 middle commit (Edit: in a hurry, thus this terse)

[SpacedOutChicken]

Check #11701 middle commit (Edit: in a hurry, thus this terse)

I looked at the middle commit, and it doesn't look like it changes the code behind the unique. Am I missing something?

[SomeTroglodyte]

It shows there are two Uniques only differing in the case of the first letter... The commit only leaves a doc comment, because I noticed in passing. Confusing, so maybe the implementation got mixed up as well? ... Looking for code usages doesn't seem so at first glance. The one with capital C is CostsResources and has references around what the UniqueTargets say... I just mentioned that because I came across that Unique just lately and you now telling it doesn't work is a fishy coincidence.

[SomeTroglodyte]

Hmmm... First, ResourcesOverviewTab is more selective than WorldScreenTopBarResources in which resources to display. That should be unified. And EmpireOverviewCategories.Resources.showDisabled has still a slightly different selectivity - not good.

• getConstructionButton gets a DTO for that Building "Check 2" without rejectionReason, even though there's 0 available 'Stuff' .
• The breakpoint in INonPerpetualConstruction.requiredResources never hit before seeing that buy button enabled
• The boolean functions in RejectionReason based on Collection.contains - did I not get rid of them? I distinctly remember moving them into flags on the RejectionReasonType... Even if done this way, they should be EnumSets not Set or even List. 'Cuz EnumSet.contains is a bitmask test and way faster than any other contains. Uh, but I only wanted to find the function producing them...
• No, that's over my head. Can't find how that is even supposed to work. Seems all of the getResourceRequirements things don't apply...

[SpacedOutChicken]

For what it's worth, "<costs [amount] [stockpiledResource]>" works exactly as advertised, consuming the stockpiled resource when available and not allowing the action when there aren't enough resources. I've also been able to approximate the effect that I want by combining "Instantly consumes [positiveAmount] [stockpiledResource]" and "Only available <when above [amount] [stockpiledResource]>". The trouble remains that "Costs [amount] [stockpiledResource]" is still a dead letter.

[SpacedOutChicken]

@yairm210 The unique still appears to be a dead letter. It doesn't cause the amount of stockpiled resources to go down and it doesn't prevent the construction of units or buildings when there aren't enough stockpiled resources to go around.

[SpacedOutChicken]

I did a little more tinkering and found that the unique does work occasionally. Specifically, it kicks in when you try to build a unit without buying it. The cost will get subtracted as the unit is build, but not right when it's finished being built. It gets subtracted in the middle of the process, apparently one turn after the unit starts being built.

The cost can also prevent the unit from being built if you haven't got enough of the stockpiled resource, but it doesn't apply right away. Instead, what happens is that the game will let you start building the unit, and then will cancel the build after one turn. The possible unit will still appear on the menu, of course, but it never lets you finish constructing it.

All of this, unfortunately, can be circumvented by buying the unit or building. Purchase it with gold instead of production and the cost never gets subtracted at all.

It gets more interesting when you look at how this affects tile improvements. If a unit has the ability to instantly create a tile improvement that costs a stockpiled resource, it can't do so if there isn't enough resource to pay for it, but if it gets built, it doesn't cost anything. If you construct the tile improvement using a normal worker instead of a unit that makes the improvement instantly, the cost has no effect; the improvement can be constructed with or without the resource.

I don't know what's going on behind the scenes, but that's what I can tell you about what happens on the front end.