Coder Social home page Coder Social logo

Comments (6)

mridgway avatar mridgway commented on June 8, 2024

Confirmed tests breaking with various versions of Express. It seems to work with Express 3, but not with Express 2. Please lock these down.

from arrow.

proverma avatar proverma commented on June 8, 2024

I was Planning to lock express with v 2.x, what tests are failing with express 3 ?

Btw I am ooo till Sunday, will look into all the pull requests first thing Monday morning, sorry for the delay.

from arrow.

mridgway avatar mridgway commented on June 8, 2024

The following error happens when arrow_server tries to run using Mojito's version of Express (2.5.2):

/Users/mridgway/Projects/mojito/node_modules/yahoo-arrow/arrow_server/server.js:89
var app = express();
          ^
TypeError: object is not a function
    at Object.<anonymous> (/Users/mridgway/Projects/mojito/node_modules/yahoo-arrow/arrow_server/server.js:89:11)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.runMain (module.js:492:10)
    at process.startup.processNextTick.process._tickCallback (node.js:244:9)

Express() changed to a function instead of an object in 3.0, meaning that arrow_server is only compatible with Express 3. (See: https://github.com/visionmedia/express/wiki/Migrating-from-2.x-to-3.x)

from arrow.

lalau avatar lalau commented on June 8, 2024

I changed that since the test was failing when we use express 3.x: https://github.com/yahoo/arrow/pull/9/files
You will need to revert the above changes if you need to use express 2.x.

from arrow.

mridgway avatar mridgway commented on June 8, 2024

I don't want to use it with Express 2.x, but because Arrow's package.json does not specify what version it works with, it assumes that it works with the already installed Express 2.x. The package.json needs to be locked down to versions of dependencies that it works with, so that it knows to install the working version if an older version already exists.

from arrow.

proverma avatar proverma commented on June 8, 2024

This is fixed now, we are using express 2.x, and all dependencies have fixed versions now.

from arrow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.