Comments (2)
deep110
commented on June 14, 2024
1
@yadav-rahul enums are just used to group specific type of constants like that is done in #27. It is purely implementation viewpoint, there is no right or wrong from coding point of view.
Though I would advise to switch to enum type. Because it would look cleaner and differentiate between Toast length and Toast type.
And for the PR, it could be merged if you fix the error so that CI build is passed.
from tastytoast.
yadav-rahul
commented on June 14, 2024
@deep110 What do you think about this? Also, Can you please review this PR #27 .
from tastytoast.
Related Issues (20)
- toast.cancel() HOT 3
- About Extendibility HOT 2
- add rtl support HOT 2
- 魅蓝3s 无法使用 HOT 4
- Duplication of toast messages HOT 4
- 完善建议 HOT 10
- Bug in animation on successive toast calls HOT 7
- Error:converting bytecode to dex...... HOT 3
- need to enhance the positioning toast HOT 1
- Problem on rtl layout
- it is not smooth on Android M
- Memory leak HOT 4
- Suggest HOT 1
- back ground color change HOT 2
- Not working in android pie sdk 28 HOT 5
- Update Request
- last version 0.1.1 not show in android pie.
- not working in some devices
- custom font for toast text
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tastytoast.