Coder Social home page Coder Social logo

Comments (7)

xzkostyan avatar xzkostyan commented on August 28, 2024

There was pull request in 20 version of ClickHouse server that saves type synonyms in table declarations and in data formats. VARCHAR is synonym for String. Earlier server versions have types canonization. So even you specify VARCHAR as source type you will get String as canonized type.

Many 3rd party tools are broken now. ClickHouse developers say that that PR is contentious and can be reverted or can lead to another changes.

I'd prefer to wait for server developers' final decision on types canonization.

from clickhouse-sqlalchemy.

durchgedreht avatar durchgedreht commented on August 28, 2024

Many 3rd party tools are broken now.
You name it! Thanks so much for the explanation!

If anybody would be able to point me to the pull request as I have hard times finding it this would be awesome! I'd like to understand the behaviour and it's consequences in full.

I can still proactively decide how to roll forward and would like to make sure I take the right decision what to use where (table DDL and creation / driver / tool). Not all are 100% under my control, so this might get a bit tricky. Currently using VARCHAR in the DDL definition using JDBC to create table, sqlalchemy (native) to read (VARCHAR) which only works when calling toString() in the statement itself. Looks quite ugly and I'd like to streamline this mess! Would using String clean this up or will this cause problems when the Pull request is reverted? Unfortunately I cannot wait that much longer and take a decision now.

This is really annoying, especially as this went into the release and there's nothing mentioned in the backwards incompatibilities list (and other fixes needed to go into production):
https://github.com/ClickHouse/ClickHouse/blob/master/CHANGELOG.md

from clickhouse-sqlalchemy.

xzkostyan avatar xzkostyan commented on August 28, 2024

I've found PR: ClickHouse/ClickHouse#8370

from clickhouse-sqlalchemy.

durchgedreht avatar durchgedreht commented on August 28, 2024

Thanks very much, this is very useful! Highly appreciate your update. Will close issue here as this is more Clickhouse dependant than a driver issue!

from clickhouse-sqlalchemy.

xzkostyan avatar xzkostyan commented on August 28, 2024

I don't know on which side this should be fixed, but it seems we can make workaround in driver.

from clickhouse-sqlalchemy.

xzkostyan avatar xzkostyan commented on August 28, 2024

PR with discussion about canonical types: ClickHouse/ClickHouse#8429 (comment)

from clickhouse-sqlalchemy.

xzkostyan avatar xzkostyan commented on August 28, 2024

Keep alias type in metadata was reverted. This fix is present in 20.3 version of server.

from clickhouse-sqlalchemy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.