Comments (4)
Hi! I was inspired by your connector when developing mine. Your dialect is pretty nice too, but there were some troubles with infi.clickhouse_orm integration, per row INSERTs, lack of declarative meta support and so on. That's why I've decided to make my own connector instead of making many PRs into your dialect and changing whole approach for SQL-generation.
But there is still a lot of work to do. Especially in HTTP connector. I'll appreciate any help and PRs!
I need some time to check what parts from your dialect can be merged with mine.
from clickhouse-sqlalchemy.
Hi again!
I've take a brief look at current version of your connector.
I assume you wanted to merge my dialect into yours. But in the current way of things it's easier to merge your connector into mine, unfortunately. And here is why:
- I haven't find fixes than can be merged into mine connector. At least now.
- HTTP transport dropping is in my short-time plans. It'll help to concentrate on dialect internals, instead of parsing and dealing with tricky escaping. Just imagine how painful parsing of
Array(Array(String))
is 😞. Switching to native transport is really a great move forward. - infi.clickhouse_orm is not really required for performing queries.
In this way of merge my codebase will replace the most of yours. So, it's kind of an ideological point.
Another choice is not to merge at all as we are using different approaches to performing queries.
What's your opinion? Yup, I realize that your project has more stars and installs.
Here is short story how we ended up with ours connector:
We were need production-ready dialect that satisfies the requirements of our project within two weeks. I've find your dialect but it seemed to be abandoned for 3 months after initial commit. Integration with infi was also broken. And unfortunately existing dialect didn't meet all the requirements. So we quickly build ours and then publish it on github later.
from clickhouse-sqlalchemy.
Hey, sorry for the late reply, I just got back from vacation. Personally I don't mind merging either way, one of the things I'd like to retain though is the HTTP transport as it's the only one that supports encryption. I can fork it though if you don't want to continue maintaining it. Other than that, my use case is just making simple SELECT queries, so anything fits.
from clickhouse-sqlalchemy.
I hope you had great vacation.
HTTP/HTTPS transport can retain if you can and will continue to support it. If you don't have time for it I'd appreciate any PR and bugfixes, but default transport should be the native one after all. If HTTP transport retains, we should get rid of infi.clickhouse_orm. One ORM inside another is not good idea. Only parsing and escaping is required, pure requests package is good enough as transport.
Do you agree with my points?
Anyway, feel free to fork.
from clickhouse-sqlalchemy.
Related Issues (20)
- Does `clickhouse-sqlalchemy` 3.0.0 support `sqlalchemy` of the version 1.4.*? HOT 5
- Create a cluster table orm class with engines.Distributed which has a logs attribute, how to use variable to indicate it?
- alembic does not autogenerate engine for clickhouse table HOT 4
- Patreon does not work HOT 1
- Add support for Date32 HOT 2
- Handling Clickhouse Alembic Migrations for Clickhouse cluster HOT 2
- Support/example for creating views HOT 2
- `create_all` for all the `MaterializedView`
- With chdb this clickhouse downsized memory database, can clickhouse-sqlalchemy support it or not?
- Support VariantType
- Table reflection for DateTime64 timezone will be extra quoted
- Alembic_Version Records disappered after clickhouse alembic migration HOT 5
- using http mode, connecting database failed when account password ends with @ HOT 2
- Support nested Map column
- Cannot seem to run ALTER command on replicas of the same shard HOT 2
- Sqlalchemy can't catch asynch's error
- query_id cannot be set with the native TCP connection
- Feature Request: Support clickhouse-connect's NEW AsyncClient wrapper HOT 5
- Nested maps, tuples, enums don't work HOT 2
- Support Lightweight DELETE Statement HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clickhouse-sqlalchemy.