Validate custom OpenMW patches about openmw-android

[akortunov]

Tested without the patch and there's no mouse in the main menu unless mouse is moved with the joystick

Are you sure? On PC mouse cursor appears in the main menu just after intro video. I see no reasons why it should behave differently on Android.

[xyzz]

0001 - this created a flash of white screen (or iirc just solid white screen?) when loading new area
0014 - usually people on Android close the app by swiping it off the drawer, in which case the save code wasn't triggered. As well, if the app is backgrounded and then gets killed due to e.g. low memory, it was not triggered.

[akortunov]

usually people on Android close the app by swiping it off the drawer, in which case the save code wasn't triggered.

In this case OS should provide application a way to quit gracefully rather than silently kill it without proper cleanup. I'd suggest to investigate SDL_APP_TERMINATING event and onTaskRemoved and onStop methods.

this created a flash of white screen (or iirc just solid white screen?) when loading new area

At least, it should be documented in the patch description, but better to investigate it - it may be an OpenMW, OSG or GL4ES bug. BTW, there was a similar regression, so the root of the issue may be the same.

[AbduSharif]

This merged now, I still use the OSG patch because the game freezes alot without it:
https://gitlab.com/OpenMW/openmw/-/merge_requests/557/diffs?commit_id=eb80c997b8255e86b86096bc4ac9218929eaeddd

[akortunov]

I see two possibilities here:

1. There is a use-case, which was not reported by xyzz
2. OSG patch just gives you a placebo effect.

Anyway, Robert Osfield in such cases says that OSG is not threadsafe, so any threading issues should be handled in the client code.

[AbduSharif]

It might be the second thing, I disabled the OSG patch for a new build and explored the game for a while, I still have a few freezes but it's still alot less than the first time I tested without it.

[AbduSharif]

I found out the additional reason for for game freezes, on my devices there's a couple of graphics drivers, it was a matter of switching back the graphics driver and never miss with it again.

[docent27]

I built the APK by disabling all patches except number 10 (for some reason it caused an error during the build, until I figured out why), the game works without problems. Are these patches really needed?

[xyzz]

0001-loadingscreen-disable-for-now.patch

Tested, the flash of white screen issue still occurs.

0002-scenemanager-disable-state-share-inc-compile.patch

removed

0003-globalmap-fix-race-vs-savegame-load.patch

removed

0004-getUVBuffer-pre-set-array-binding-to-avoid-thread-ra.patch
0003-Array-make-possible-to-use-thread-safely-with-setTex.patch

both removed

0009-windowmanagerimp-always-show-mouse-when-possible-pat.patch

Tested without the patch and there's no mouse in the main menu unless mouse is moved with the joystick, keeping the patch for now.

0005-android-Revert-UI-dimensions.patch
0013-android-Update-default-settings-for-android.patch

keeping both until openmw implements the aforementioned platform-specific config feature

0014-settingswindow-save-user-settings-file-when-ok-is-pr.patch

Also keeping this one unless somebody implements the version using SDL_APP_TERMINATING, I don't really have time or willingness to work on that.

---

Believe this should take care of everything so I'm closing this issue, feel free to open more specific issues if you wish.

[akortunov]

Also did you try to init mCursorActive field to true in the WindowManager constructor?

[xyzz]

Are you sure?

yep

Also did you try to init mCursorActive field to true in the WindowManager constructor?

No I haven't tried.