getPermissions does not resolve/reject about cordova-device-accounts-v2

[xUnholy]

Interesting. I'll have a look in the morning If I get a spare minute or two, feel free to fork and try debug or improve yourself, always happy to have more people contribute

[endareBrock]

I think the 'only google' is straightforward

android api says:
an optional string array of account types., i think leaving the 'com.google' out will give all the options

The not returning problem is maybe related to the fact there is no return value ? and the other methods do.

[endareBrock]

Can confirm that replacing new String[]{"com.google"} by null, lets you choose between all your accounts. Right now i am struggling with the second issue

[endareBrock]

I almost figured it out.
You need to set the callbackContext locally and do following

  private void getPermissions() {
    AccountManager manager = AccountManager.get(cordova.getActivity().getApplicationContext());
    Intent accountIntent = manager.newChooseAccountIntent(null, null, null, null, null, null, null);
    cordova.setActivityResultCallback(this);
    cordova.getActivity().startActivityForResult(accountIntent, VISIBILITY_VISIBLE);
  }

  @Override
  public void onActivityResult(int requestCode, int resultCode, Intent intent){
    if(requestCode == VISIBILITY_VISIBLE && this.callbackContext != null){
        this.callbackContext.success("Success");
    } else {
        this.callbackContext.error("Invalid requestCode: " + requestCode);
    }
  }

It fires the success callback but reaches the reject of the app.

[endareBrock]

i managed to write this but it still needs improvements.
Would you mind taking a look ? My Android knowledge is far, far away.

  private void getPermissions(String type) {
    AccountManager manager = AccountManager.get(cordova.getActivity().getApplicationContext());
    Intent accountIntent = manager.newChooseAccountIntent(null, null, new String[]{type}, null, null, null, null);
    cordova.setActivityResultCallback(this);
    cordova.getActivity().startActivityForResult(accountIntent, VISIBILITY_VISIBLE);
  }
  private void getPermissions() {
      AccountManager manager = AccountManager.get(cordova.getActivity().getApplicationContext());
      Intent accountIntent = manager.newChooseAccountIntent(null, null, null, null, null, null, null);
      cordova.setActivityResultCallback(this);
      cordova.getActivity().startActivityForResult(accountIntent, VISIBILITY_VISIBLE);
    }

  @Override
  public void onActivityResult(int requestCode, int resultCode, Intent data){
    if(requestCode == VISIBILITY_VISIBLE && this.callbackContext != null){
         this.callbackContext.success("Success " + data.getStringExtra(AccountManager.KEY_ACCOUNT_TYPE +" "+ data.getStringExtra(AccountManager.KEY_ACCOUNT_NAME)));
    } else {
         this.callbackContext.error("Invalid requestCode: " + requestCode);
    }
  }

This would have the option to give a type argument (instead of the "google.com")

[xUnholy]

Separating the account type and callback issues #11

[xUnholy]

This would be much easier to review in a pull request - additionally, I think the getPermissions() function should actually return all accounts, then the type should be handled by the getAccounts() function which already handles the type to receive.

[xUnholy]

I've been working on making an easy usage guide for this plugin with an ionic application. Check it out here, perhaps we can add this to the examples once we also get this working. https://github.com/xUnholy/cordova-device-accounts-example

[xUnholy]

Please review and test the following - I've used some of your logic and tweaked it to solve the underlying issue with the promise resolving incorrectly which was a bug. Effectively the promise would be rejected even though internally it resolved.

[xUnholy]

Pull request can be reviewed here - #12