Duplicate transactions about xrpl.js

[sublimator]

This could be caused by serverStatus messages triggering recalculation of tx_json.Fee

This would mean that the transactionID (tx._hash) would be recomputed upon resubmit (timeout etc) and it would be possible that validated transaction messages wouldn't be found in the hash lookup cache, while consuming a Sequence, and thus triggering Sequence++ before resubmission.

Every transactionID that a given transaction has been submitted with must be stored, and checked against incoming validated transaction messages.

The role of tx._hash could perhaps be better filled by something akin to tx._submittedHashes = [...] ?

[sublimator]

It doesn't seem like submit response handlers are muted upon a request timeout: https://github.com/ripple/ripple-lib/blob/develop/src/js/ripple/transactionmanager.js#L339-L345

That could potentially lead to multiple concurrent streams of resubmission logic

[wltsmrz]

Submit response handlers are muted upon a request timeout. If you use request.timeout(milliseconds, fn) and the request doesn't receive a success or error within milliseconds, the timeout function will prevent future events from being emitted on the request. i.e. when a request times-out, you can expect that no more events will be emitted from it.

[sublimator]

All I saw was bail outs when tx.finalized

Is there something built in to EventEmitter or something?

[sublimator]

https://github.com/ripple/ripple-lib/blob/develop/src/js/ripple/request.js#L98-L103

[sublimator]

Ah, I see

[wltsmrz]

Assume that this has been fixed with recent updates to transactionmanager.js until we can confirm otherwise.