Comments (8)
@develoQ I am up for removing lodash all together if the methods used can be done in modern js.
from xrpl.js.
Done as part of 3.0
from xrpl.js.
@ckniffen Exactly, most things are very easy with some map/reduce/filter/... these days.
from xrpl.js.
I believe I tried to remove as much lodash as possible at some point, but in some places there were really nice functions like groupby
and omitby
that were hard to replace.
from xrpl.js.
groupby
would be very easy with a reduce fn?
Ugly piece of code, idea is clear, reducer could be a more generic fn of course.
const people = [
{ name: 'Nienke', gender: 'F' },
{ name: 'Wietse', gender: 'M' },
{ name: 'Arwen', gender: 'F' },
{ name: 'Quinn', gender: 'M' },
]
const sortedPeople = people.reduce((a, b) => {
if (!a[b.gender]) {
Object.assign(a, { [b.gender]: [] })
}
a[b.gender].push(b)
return a
}, {})
from xrpl.js.
@develoQ @intelliot is it done. I am keen in learning xrp and want to pick this
from xrpl.js.
@aruns05 when working on this the solution should reduce the webpack bundle size.
from xrpl.js.
@aruns05 I went ahead and did this as part of our effort to reduce the bundle size of xrpl.js. Let me know if I missed anything in #2378.
There will be more PRs to reduce size in the next few weeks.
from xrpl.js.
Related Issues (20)
- DeprecationWarning about `punycode` on Node.js 21 HOT 3
- 'nft_info' method is unknown HOT 2
- Full custom definition support HOT 5
- Discrepancy in Wallet Address Generation from Seed on Mainnet HOT 3
- Replace use of `convertStringToHex`/`convertHexToString` with `stringToHex`/`hexToString` HOT 3
- Use Network ID to determine the correct faucet to use
- `npm link xrpl` doesn't work properly HOT 2
- `TransactionStream` missing `close_time_iso` field
- Response of `ledger` command missing `close_time_iso` field HOT 1
- Response of `ledger` command missing transaction `hash` field
- Using `@xrplf/isomorphic/***` from `.mts` file results in `ERR_MODULE_NOT_FOUND` error
- Feature request for ledger_index
- Link to [`rippled` Signing Library] is broken.
- trouble using TransactionType: ClaimReward HOT 3
- [NotConnectedError(Expected HTTP 101 response but was '418 ', { isTrusted: false, message: [Getter/Setter] })] HOT 1
- Secret phrases to secret key (starting with s...) HOT 1
- Unable to send payment transaction HOT 1
- Use `client.connect()`, `client.submitAndWait()`, `client.getLedgerIndex()` etc. with `api_version: 1` HOT 3
- TransactionStream type is wrong when using API version 2
- XRPL Developer Discord HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xrpl.js.