Add Cross-Currency Payments about xrpl-py

[ledhed2222]

You have it opposite. Check out the documentation for the payment transaction - https://xrpl.org/payment.html#main_content_wrapper especially the payment types section on cross currency payments - https://xrpl.org/payment.html#types-of-payments

To clarify, anything we add in this domain would just potentially simplify this operation for a common use case. You can do full cross currency payments using this library already, so there's nothing "missing" in xrpl-py around this functionality.

[ledhed2222]

closing - please open another issue if you have more questions! feel free!

[ledhed2222]

(edited for version 1.1.0 to show easier imports)

hey there @wojakkk, adding helper functions for cross currency payments is in our backlog. we'll be likely tackling it after the 1.1 release (coming soon!). in the meantime, you can still use the full capabilities of the ledger to make cross currency payments by submitting Payment and Offer transactions directly, so you don't have to wait for any helper functions to do this. below code would send a cross currency MXN -> JPY payment as you describe

from xrpl.models import IssuedCurrencyAmount, Payment
from xrpl.transaction import safe_sign_and_submit_transaction
from xrpl.clients import JsonRpcClient
from xrpl.wallet import Wallet

wallet = Wallet(seed, 0)
client = JsonRpcClient(url)
safe_sign_and_submit_transaction(
  Payment(
    account=wallet.classic_address,
    amount=IssuedCurrencyAmount(
      currency="JPY",
      issuer="11231",  # you would need to know a JPY issuer to use
      value="100",
    ),
    send_max=IssuedCurrencyAmount(
      currency="MXN",
      issuer="11231",  # whatever the issuer is of the MXN you want to send
      value="1",
    ),
    destination="1231231",  # address of receiver
  ),
  wallet,
  client,
)

Thanks @ledhed2222, great to hear that its being developed soon!

@ledhed2222 So is this how the code that you linked me works? :

amount var = the currency/amount being used in the transaction
send_max var = the currency/amount that will be exchanged for amount_var and sent to destination address

Me -> "amount" currency -> (exchanged for send_max, market price)-> "send_max" currency -> destination

How does this particularly work, im quite confused.