How to fix private_key OutOfRange about starknet-rs

[xJonathanLEI]

Correct. Note that you don't need to directly import starknet-signers. It's re-exported through the umbrella starknet crate as well. So you can do something like starknet::signers::xxxx.

[xJonathanLEI]

Technically Starknet.js is wrong here. When you randomly generate 32 bytes it's very likely the result is not a valid field element, as the Starknet field element is only 252 bits (it doesn't even make use of all of 252 bits, meaning that even if you randomly generate just 252 bits (instead of 256) you could still get an invalid value). Starknet.js is incorrect in that it should have rejected your input. This is not a bug in starknet-rs. starknet-rs is correctly pointing out that your input is invalid.

That said, if you do want to use that key, you would need to study the Starknet.js code to understand how it's turning your invalid input into a valid one (it has to happen somewhere inside their code, after all). Then, you can use that valid, in-range, field element as private key in starknet-rs.

I haven't looked but my guess is that they simply take the your input and mod P. If that's the case you can simply do that too and use the result for starknet-rs.

[whyubel1eve]

thank u for reply, I will look into it.

[whyubel1eve]

Hi @xJonathanLEI. I think I might need to give up that old private key. If I want to generate a valid private key that can be used in starknet-rs, what should I do?
use SigningKey::from_random from starknet-signers instead?