Comments (6)
I agree with this, I was going to suggest a trait for account deployers but I see you already defined it.
from starknet-rs.
Damn. I just wanted to jot some notes on the revamp plan but ended up writing an essay lol.
Spamming your inboxes since you guys contributed a lot to this library: @milancermak @fracek haha. Just FYI, can totally ignore, but feedbacks are welcome!
from starknet-rs.
great initiative! not sure what kind of light can I shed but the address it's expected to be 0x041a78e741e5af2fec34b695679bc6891742439f7afb8484ecd7766661ad02bf
when deployed from 0 with salt 0.
the verified code can be found on the above link, with the same interface as in the UDC Proposal. further documentation on usage, caveats, and design rationale is on the way.
from starknet-rs.
@martriay Thanks! I was mainly wondering if the interface and address calculation behavior (mainly salt) will change cuz I will be hard-coding it inside the library, along with the address of latest UDC, so it might silently break users at runtime if the interface changes.
But hey, StarkNet itself still makes breaking changes all the time. Maybe at this point it doesn't matter lol. Or maybe a better approach is simply to not ship with an address.
from starknet-rs.
the address is expected to stay, although any future changes to the code will result in a different one. interface changes are even less likely, but it will depend on the ecosystem.
what we do in nile is to take an UDC address parameter with a default value for the standard one. this also allows users to use their own deployer contracts even if it's not the UDC
from starknet-rs.
Yeah I figure I wasn't thinking straight and thought it might break people if the default address changes lol. It's actually the opposite: it breaks if users supply their own address and the UDC interface changes. All good now. Thanks!
from starknet-rs.
Related Issues (20)
- Make input for Accout::sign_execution publicly constructable HOT 3
- Remove `infinity` flag from `ProjectivePoint` HOT 3
- Migrate to starnet-types-rs Felt?
- Explanation: Comments have been added to explain the general purpose of the script and specific functions. Variables have more descriptive names to improve readability. Logic for cleaning and creating the target directory is clarified. Additional comments in the loop sections to explain the purpose of each step. Comments added for clarification in some loop steps.
- No reference to `result.transactions[0].sender_address` property in `starknet_getBlockWithTxs` method. HOT 1
- Support for STRK Fee Payment in RPC HOT 1
- `compute_hash_on_elements` could accept any iterator on `FieldElement` HOT 4
- Divide by zero panics in `bigint_mul_mod_floor` and `mul_mod_floor` if modulus set to 0 HOT 3
- `deploy_argent_account` has error
- Extend JSON-RPC transport capabilities for batch requests HOT 1
- Add more clippy lint rules HOT 2
- Add warn on `clippy::needless_pass_by_value` HOT 1
- Unify `pub enum TransactionStatus` variants HOT 1
- replace Poseidon implementation by `types-rs` HOT 2
- replace Pedersen implementation by `type-rs` HOT 2
- UDC: Contract deployment selector mismatch HOT 1
- Support argent v4 accounts
- Remove `async_trait`
- Panic using `get_block_with_txs` HOT 1
- Feature Request: Support for devnet-rs test provider in starknet-rs
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from starknet-rs.