Coder Social home page Coder Social logo

Refactor sysfs usage in HAL about xrt HOT 7 CLOSED

xilinx avatar xilinx commented on August 15, 2024
Refactor sysfs usage in HAL

from xrt.

Comments (7)

stsoe avatar stsoe commented on August 15, 2024

I agree, this looks like some dangerous implicit assumptions about sysfs. Absolutely should be factored into one access point of some sort.

from xrt.

maxzhen avatar maxzhen commented on August 15, 2024

I'll clean it up.
What is the danger you're seeing here other than duplicate code?

from xrt.

rradjabi avatar rradjabi commented on August 15, 2024

from xrt.

maxzhen avatar maxzhen commented on August 15, 2024

Oops, I just removed myself from the assignee. Maybe all of us, in this team, should have write permission?

from xrt.

sonals avatar sonals commented on August 15, 2024

Please use C++ templatized methods to modularize this code. The same templatized function should be used to read data types of different types and will be type safe.

from xrt.

hcneema avatar hcneema commented on August 15, 2024

post 2018.2_XDF

from xrt.

maxzhen avatar maxzhen commented on August 15, 2024

Implemented in PR#399.

from xrt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.