Coder Social home page Coder Social logo

Normalize edge "order" and "size" about xgi HOT 9 CLOSED

xgi-org avatar xgi-org commented on August 20, 2024
Normalize edge "order" and "size"

from xgi.

Comments (9)

leotrs avatar leotrs commented on August 20, 2024

FWIW, I'd rather keep order so that we don't have problems when implementing simplicial complexes.

from xgi.

iaciac avatar iaciac commented on August 20, 2024

I'm more than OK with order!

from xgi.

maximelucas avatar maximelucas commented on August 20, 2024

Good point. I'm fine with order too.

from xgi.

nwlandry avatar nwlandry commented on August 20, 2024

I'm okay with doing this, but will admit that this will be a bit of habit for me to break :). Along these lines, is the biggest remaining change the IDDegreeView class?

from xgi.

nwlandry avatar nwlandry commented on August 20, 2024

One thing that probably will need to change is that we may not be able to effectively use IDDegreeView class as a base class if we choose to use edge_order instead of edge_size, because degree and edge order will be off by one from each other.

from xgi.

leotrs avatar leotrs commented on August 20, 2024

Oh jeez that complicates things.

from xgi.

leotrs avatar leotrs commented on August 20, 2024

Related to #82

from xgi.

nwlandry avatar nwlandry commented on August 20, 2024

This was fixed with EdgeStats, no?

from xgi.

leotrs avatar leotrs commented on August 20, 2024

Kind of. We now have both order and size, so any EdgeStat (or any other part of the codebase that is aware of the stats package) can choose which one to use. So on that front we are fine.

What has not been addressed is the fact that currently, SimplicialComplex inherits from Hypergraph and that is Very Messy And Bad.

I guess this particular issue is about the first problem, not the latter, so let's close this. For more discussion of the latter, continue on #82 .

from xgi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.