Comments (7)
Compat for DiagonalFences is theoretically possible though in practice it's most likely going to be pretty ugly because I would need to access code in DiagonalFences that is not exposed via an API and can therefore not be considered as stable over long term.
I will look into the feasibility of this and get back to you. Should this not be doable in a maintainable way, then I will add the Framed Fences to the exclusion Tag from DiagonalFences in order to avoid any confusion in the future.
Pinging @Fuzss in case you have any input on this.
from framedblocks.
Ah, thanks for looking into it!
from framedblocks.
Hi there, I've just pushed an update for Diagonal Fences which includes fences from Framed Blocks in the exclusion tag for now.
If you want to work on compat I'm happy to make whatever changes you need on my end.
from framedblocks.
Thanks for the heads up.
At a first glance, the only thing I need is to have the BlockState properties declared as API. Then I can generate the quads without having to worry about accessing internals.
EDIT: just checked and saw that you did exactly that a few hours ago, that should be enough to make this work
from framedblocks.
This was far easier than I assumed in the beginning.
from framedblocks.
Wow, nicely done!
About the tag, I just did a quick test and it's working fine...
But it only prevents newly placed fences from connecting diagonally, maybe you still had some old ones?
from framedblocks.
I opened an issue about it on you repo ;)
from framedblocks.
Related Issues (20)
- [Feature]: Link between framed slope slab / framed slope panel and framed inner prism corner. HOT 1
- [Mod Support]: Kitchen block functionality of CookingForBlockheads 1.18.2 HOT 3
- 1.19.2 Rendering [Bug]: Z-Fighting with Obsidian Pressure Plate HOT 4
- [Feature]: FTB Ultimine idea HOT 4
- [Bug]: Startup crash on Forge: Sodium/Iris not found?? (Not available on Forge afaik) HOT 4
- [Bug]: Cooking For Blockheads - Kitchen tile shows invisible HOT 4
- [Question]: HOT 2
- [Feature]: Framed Vertical Bars HOT 1
- cannot place framed slope slab upside down [Bug]: HOT 1
- [Feature]: Remove Glass Border when placing multiple framedblocks with glass in them HOT 2
- dragon can't destroy block HOT 4
- [Bug]: "Exit Code 1", possible mod conflict HOT 2
- [Bug]: framed signs with create mod trains HOT 1
- [Bug]: framed doors cant open on create trains/ HOT 1
- [Feature]: Vertical double stairs HOT 1
- [Bug]: Create Integration broken on latest Create HOT 6
- [Bug]: One-Way Window causes translucent blocks to not render properly HOT 2
- [Crash]: New DiagonalFences update crashes on startup HOT 5
- [Crash]: Game crashing when using Effortless Building HOT 4
- [Bug]: Does not accept transparent glasses from the wallpapercraft mod - A fresh roll HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framedblocks.