Coder Social home page Coder Social logo

Comments (7)

XFactHD avatar XFactHD commented on August 16, 2024 1

Compat for DiagonalFences is theoretically possible though in practice it's most likely going to be pretty ugly because I would need to access code in DiagonalFences that is not exposed via an API and can therefore not be considered as stable over long term.

I will look into the feasibility of this and get back to you. Should this not be doable in a maintainable way, then I will add the Framed Fences to the exclusion Tag from DiagonalFences in order to avoid any confusion in the future.

Pinging @Fuzss in case you have any input on this.

from framedblocks.

WenXin20 avatar WenXin20 commented on August 16, 2024

Ah, thanks for looking into it!

from framedblocks.

Fuzss avatar Fuzss commented on August 16, 2024

Hi there, I've just pushed an update for Diagonal Fences which includes fences from Framed Blocks in the exclusion tag for now.
If you want to work on compat I'm happy to make whatever changes you need on my end.

from framedblocks.

XFactHD avatar XFactHD commented on August 16, 2024

Thanks for the heads up.
At a first glance, the only thing I need is to have the BlockState properties declared as API. Then I can generate the quads without having to worry about accessing internals.

EDIT: just checked and saw that you did exactly that a few hours ago, that should be enough to make this work 👍

from framedblocks.

XFactHD avatar XFactHD commented on August 16, 2024

This was far easier than I assumed in the beginning.

from framedblocks.

Fuzss avatar Fuzss commented on August 16, 2024

Wow, nicely done!

About the tag, I just did a quick test and it's working fine...
But it only prevents newly placed fences from connecting diagonally, maybe you still had some old ones?

from framedblocks.

XFactHD avatar XFactHD commented on August 16, 2024

I opened an issue about it on you repo ;)

from framedblocks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.