Comments (7)
Thank you for your issue! Yes adding that API would be appreciated. As for where it should go, I would look up the octokit JS API and see where they put it
from octocrab.
Understood! I'll fork the repo and get started on it.
from octocrab.
It looks like getCommit
is under the repos
API (link), similar to listCommits
. I'm curious whether you prefer using repos
or commits
, because it looks like createCommitComment
is also under repos
(link), whereas your crate has it under commits
at octocrab::commits::CommitHandler::create_comment
. The GitHub docs suggest that the /commits
endpoints are distinct from /repos
, but they all ultimately fall under the/repos
endpoint. If we put this API under repos
, I'm guessing this would require a new GetRepoCommit
model, since the response spec is different than the RepoCommit
one.
from octocrab.
Ah yeah, I think it should go under commits, ultimately itβs very similar to repos because it does require you to specify a repo.
from octocrab.
So, I spent a few hours yesterday figuring out why the additions
and deletions
fields weren't populated. I used the PullRequestHandler::list
method.
Reading this issue, am I correct that some (all?) of the optional fields in PullRequest
are only populated when you do a call to fetch the information for that individual Pull Request?
That's good to know. Is this documented somewhere, and I just missed that detail?
from octocrab.
I just verified that this is indeed the case using:
gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/repos/OWNER/REPO/pulls/PULL_NUMBER
Without PULL_NUMBER
, many details are missing from the listed pull requests.
from octocrab.
That's good to know. Is this documented somewhere, and I just missed that detail?
I don't know if it's documented anywhere in the GitHub API, but we should probably add a note to the list method stating it.
from octocrab.
Related Issues (20)
- Add generate-notes URL handler
- compilation failure with `default-features = false` HOT 1
- Cannot directly pass SecretString for token auth HOT 2
- Expose status_code in GithubError HOT 3
- Reference::Commit is based on a documentation error
- Authentication breaks for "child" clients HOT 1
- Should `RateLimit::reset` be a `u64`? HOT 1
- create_workflow_dispatch failed with GitHubError HOT 2
- Model bug in DiffEntry: Submodules have `"blob_url": null` and `"raw_url": null`
- Superseded by #625
- [pulls] Pull request review create/edit API HOT 1
- list_collaborators with permission
- Support remove_assignees on issue API
- Creating pr request with "head_repo" parameter
- field 'author' and 'committer' of type 'RepoCommitPage' are wrong HOT 1
- Support procuring a user access token from an oauth code HOT 1
- no method to create a repository hook
- Return result instead of panic when returning an `installation` Octocrab instance HOT 1
- Builder add_retry_config requires intermediate variable binding
- Add support for `latest` in the `UpdateReleaseBuilder` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octocrab.