gcc compiler warning about potential buffer overflow about gmsynth.lv2

[agraef]

Too lazy to fork and do a PR right now, but there's the required change (inline as stupid GH doesn't allow me to attach a patch here):

diff --git a/fluidsynth/src/fluid_defsfont.h b/fluidsynth/src/fluid_defsfont.h
index 29f3fd9..50f987c 100644
--- a/fluidsynth/src/fluid_defsfont.h
+++ b/fluidsynth/src/fluid_defsfont.h
@@ -435,7 +435,7 @@ struct _fluid_defpreset_t
 {
   fluid_defpreset_t* next;
   fluid_defsfont_t* sfont;                  /* the soundfont this preset belongs to */
-  char name[21];                        /* the name of the preset */
+  char name[22];                        /* the name of the preset */
   unsigned int bank;                    /* the bank number */
   unsigned int num;                     /* the preset number */
   fluid_preset_zone_t* global_zone;        /* the global zone of the preset */

[x42]

This patch will have to go upstream to fluidsynth.
see https://github.com/x42/gmsynth.lv2/blob/master/fluidsynth/README

[agraef]

sf.net is down, as usual.

[x42]

Is this an issue anyway? Bank and preset have limted range in MIDI. "Bank,Preset" and terminating NULL is only 12 chars. The remaining 9 digits are more that sufficient for bank (two or 5 digits, up to 2^14) + preset (3 digits -- up to 2^7)

[agraef]

Yeah, it's probably just a theoretical possibility. So then it's just to make gcc happy and get rid of that warning. :)

[x42]

upstream issue:
https://github.com/FluidSynth/fluidsynth/blob/768fa225db7a9bcb054a1ff300679baf31188468/src/sfloader/fluid_defsfont.h#L146